Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync49 #4

Merged
merged 107 commits into from
Apr 9, 2019
Merged
Changes from 1 commit
Commits
Show all changes
107 commits
Select commit Hold shift + click to select a range
a7e50c0
GH-4585: Fixed the selection state issue.
Mar 18, 2019
8968ac2
Proceed runInTermianl request in a sidecar container
tolusha Mar 18, 2019
0b5017b
Initial commit to add 'Run Selected Text' functionality. Signed-off-b…
jgbradley1 Mar 17, 2019
268f96b
Open new terminal if none exist
jgbradley1 Mar 18, 2019
a3c7420
Simplified getText() with cleaner code
jgbradley1 Mar 18, 2019
d03bddc
Improved text selection behavior
jgbradley1 Mar 20, 2019
591dbb5
Use all the type hierarchy levels the server sends (fixes #4540)
HighCommander4 Mar 15, 2019
ca07605
Implemented Toolbar support for sidepanels and changed sidepanel tabs.
jbicker Mar 18, 2019
73b1a81
[plugin] use the native toolbar for view container
akosyakov Mar 19, 2019
6d5c14a
[plugin] render view container icon
akosyakov Mar 19, 2019
84b719d
[workspace] add spliceRoots
akosyakov Mar 18, 2019
fc603c6
[plugin] fix #4240: implement workspace.updateWorkspaceFolders
akosyakov Mar 18, 2019
a27cbd0
[preference] fix parsing of settings from workspace files
akosyakov Mar 19, 2019
7efb824
Make the diff navigation header static
vince-fugnitto Mar 19, 2019
c3e976b
Fix #4595: 'Reveal in Files' error
zixuemeng Mar 18, 2019
9e69688
Set the minimum perfect scrollbar length
vince-fugnitto Mar 20, 2019
6dc2079
Make keybinding widget search static
vince-fugnitto Mar 19, 2019
e35ba88
Adjust open workspace explorer button alignment
vince-fugnitto Mar 20, 2019
43c2a13
Fix spelling mistake in block comment
zixuemeng Mar 21, 2019
2519e53
use VS Code icons in a tabbar toolbar
akosyakov Mar 20, 2019
7c7b08f
fix #4633: set git diff title icon
akosyakov Mar 21, 2019
16d526d
Update scrollbar width to a larger value
vince-fugnitto Mar 20, 2019
6a07cec
[plugin] fix #4621: apply only valid configurations as schemas
akosyakov Mar 20, 2019
e38fd2a
Add missing git diff caption
vince-fugnitto Mar 21, 2019
824fbfc
Involve selection service in tree view on plugin side
vzhukovs Mar 21, 2019
7552e80
Don't let sidepanel titles wrap.
jbicker Mar 21, 2019
7e8b910
Added debug console icon
vince-fugnitto Mar 21, 2019
25d715f
Aligned widget content in sidepanels to header title.
jbicker Mar 20, 2019
8ca8e64
[shell] center side bar icons
akosyakov Mar 21, 2019
0020936
reorder views in side bars to mimic VS Code order
akosyakov Mar 21, 2019
024a835
Add missing search-in-workspace icon tooltips
vince-fugnitto Mar 22, 2019
c596067
[debug] fix #4648: preferences to control view, console and location …
akosyakov Mar 22, 2019
cff9ac4
fix #4658: improve rendering of fa icons in sidebars
akosyakov Mar 22, 2019
58bad43
fix #4657: use browser preview icon from VS Code for mini-browser pre…
akosyakov Mar 22, 2019
06d69ec
Added collapse all toolbar item to the explorer
vince-fugnitto Mar 21, 2019
8c9ecd8
[navigator] don't apply collapse all item to all widgets
akosyakov Mar 22, 2019
56e8b23
fix #4651: apply default configuration overrides properly
akosyakov Mar 21, 2019
87db1e0
Fix minor typo in tree.spec.ts
vince-fugnitto Mar 21, 2019
2bf6374
keep properties in definitions of contributed tasks
Mar 21, 2019
bfa0621
Set background of webview-icons to 'none'.
jbicker Mar 22, 2019
7d13d59
editorconfig: Apply properties to Monaco editor when opening/switchin…
simark Mar 15, 2019
8f9ba43
[Styling] various style changes
svenefftinge Mar 22, 2019
3231c64
[core] disabled expand animation
svenefftinge Mar 23, 2019
89c3e75
fixed typo
theBadT Mar 23, 2019
0b833d5
typehierarchy shortcut is now ctrlcmd+shift+h
theBadT Mar 23, 2019
74d7142
Fix incorrect styling
vince-fugnitto Mar 23, 2019
33e4c2a
[Core UX] Don't close on CTRL+W
svenefftinge Mar 25, 2019
b5b9820
Fix tree node capitalization outside of nav
vince-fugnitto Mar 25, 2019
9c8e29b
fix #4661: fix content assist in user preferences
akosyakov Mar 22, 2019
ea77750
[core] Fixed broken wheel listener
svenefftinge Mar 25, 2019
4d74d28
[UX] indicate active widgets on bottom panel
svenefftinge Mar 25, 2019
5cbb4f1
[shell] fix #4697: reset prevent close on keyup and beforeunload
akosyakov Mar 25, 2019
29299e4
Add preferences to handle clang-tidy functionality when clangd v9+ is…
lmcbout Mar 14, 2019
303aeeb
Add line numbers to search-in-workspace results
vince-fugnitto Mar 22, 2019
8d9525a
added tests for interfaces Tree, TreeExpansionService
theBadT Mar 20, 2019
59451b8
fix #3674: fix ToolbarAwareTabBar detachment
akosyakov Mar 25, 2019
68795ec
Promise.reject uses Error instead of strings
theBadT Mar 24, 2019
7ce5bdb
Update file-icons in sidepanels to not have backgrounds
vince-fugnitto Mar 25, 2019
1df2a80
make sidebar widgets closable
uniibu Mar 25, 2019
24fe0ee
Add files.associations property
tolusha Mar 26, 2019
b862dbd
Update callhierarchy tree styling
vince-fugnitto Mar 26, 2019
cea1cf9
Update readme screenshot
vince-fugnitto Mar 21, 2019
3ebfd46
Improved performance for the file rename action
federicobozzini Mar 22, 2019
6d605f8
Add missing licenses
vince-fugnitto Mar 26, 2019
21d54a7
.gitignore plugins folder
paul-marechal Mar 26, 2019
ccaf4b5
Don't redeploy already initialized plugins
tolusha Mar 26, 2019
9043bc1
Fix adding files.associations property
tolusha Mar 27, 2019
d47ae60
set core.toggale.bottom.panel's priority to -1000
uniibu Mar 26, 2019
3682c4d
Fix #4740
zixuemeng Mar 28, 2019
ba47814
Bump VS Code API version
benoitf Mar 28, 2019
5a39e78
Added NOTICE.md file
marcdumais-work Mar 27, 2019
b1533e2
Update the explorer to handle multiple-root workspaces
vince-fugnitto Mar 27, 2019
fbe20de
change dependency vscode-nsfw to Axosoft/nsfw
Jan 18, 2019
ff7309d
Added LanguageConfiguration (comments, brackets, pairs) for Perl
toonvd Mar 26, 2019
1783ccd
Update CHANGELOG for 0.5.0 release
vince-fugnitto Mar 28, 2019
3a2dbbf
publish v0.5.0
marcdumais-work Mar 28, 2019
0fff080
fix #2566: report fs events for real paths
akosyakov Mar 28, 2019
6a8b229
[tree] fix handling global selection
akosyakov Mar 27, 2019
9b6234e
fix #4088: Add 'Upload Files...' menu entries
akosyakov Mar 27, 2019
6af076b
eclipse/che-theia#103 fix 'getTask' method
evidolob Mar 29, 2019
6365339
Publish typedoc to github pages on deploy
benoitf Mar 21, 2019
ccc0eec
fix #4524 add files.enableTrash preference
akosyakov Mar 31, 2019
6133f8d
fix 4334: allow to override default preference values for application
akosyakov Apr 2, 2019
b0a7da6
allow promises on validate. fix inconsistent selection, add CHANGELOG
uniibu Apr 2, 2019
9eb7f4e
fix #4776: turn off autoSave by deafult
akosyakov Apr 2, 2019
bd91f64
Set a minWidth and minHeight in frontend-generator for electron app.
jbicker Apr 2, 2019
de5b900
Allow to choose through CLI the VS Code API version that is provided …
benoitf Apr 1, 2019
5862b11
Use external absolute link for logo
benoitf Apr 2, 2019
0dab9af
Add ability to configure task
RomanNikitenko Apr 3, 2019
23fd73a
remove docs script in each package as we now have the root documentat…
benoitf Apr 2, 2019
a0b7396
[file-search] fix #4599: don't mess around with given include patterns
akosyakov Mar 18, 2019
60c3e36
[file-search] excludePatterns without magic
akosyakov Mar 19, 2019
2ccaff6
[filesystem] Fixes #4792 XSS vulnerability.
caseyflynn-google Apr 2, 2019
67043f5
Don't rewrite debug capabilities
svor Apr 2, 2019
b1df8fc
Check whether selected item in dialog is non-leaf node
vzhukovs Apr 3, 2019
9fdc224
set minimum value for lineHeight and fontSize and align it with VS Code
uniibu Apr 4, 2019
8477580
Fix incorrect method name for registerReferenceProvider
vince-fugnitto Apr 2, 2019
95c962c
Add CodeActionKind intersects() Plugin API
vince-fugnitto Apr 2, 2019
ddd2dd8
fix #4459: register text decoration key in proper service
akosyakov Apr 6, 2019
60b6aab
fix gotodefinition failure when editor in preview mode
yeweiasia Apr 4, 2019
e1fb491
Fix plug-in path selection dialog for hosted instance
mmorhun Apr 8, 2019
27750e3
Handle copying when source and target destinations are the same
vince-fugnitto Apr 4, 2019
11ce1e7
Update electron and node packages
thegecko Dec 7, 2018
7d2959f
update gitpod to use node 10
akosyakov Apr 8, 2019
28df6ba
Remove no longer used interfaces from java-protocol.ts
HighCommander4 Apr 7, 2019
b3e8aa3
[vscode] fix #4339: focus and reveal webviews properly
akosyakov Apr 5, 2019
237e6b2
Support icons in tail decorators
thegecko Apr 4, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Core UX] Don't close on CTRL+W
Registers event listener which make sure that
window doesn't get closed if CMD/CTRL W is
pressed. Too many users have that in their
muscle memory. Chrome doesn't let us rebind or
prevent default the keybinding, so this at least
doesn't close the window immediately.

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge committed Mar 25, 2019
commit 33e4c2a180a2441a36ecd87c30f89dd578a87451
33 changes: 28 additions & 5 deletions packages/core/src/browser/common-frontend-contribution.ts
Original file line number Diff line number Diff line change
@@ -30,7 +30,7 @@ import { AboutDialog } from './about-dialog';
import * as browser from './browser';
import URI from '../common/uri';
import { ContextKeyService } from './context-key-service';
import { OS } from '../common/os';
import { OS, isOSX } from '../common/os';
import { ResourceContextKey } from './resource-context-key';
import { UriSelection } from '../common/selection';

@@ -216,6 +216,7 @@ export class CommonFrontendContribution implements FrontendApplicationContributi
this.contextKeyService.createKey<boolean>('isWindows', OS.type() === OS.Type.Windows);

this.initResourceContextKeys();
this.registerCtrlWHandling();
}

protected initResourceContextKeys(): void {
@@ -580,11 +581,33 @@ export class CommonFrontendContribution implements FrontendApplicationContributi
this.aboutDialog.open();
}

protected shouldPreventClose = false;

/**
* registers event listener which make sure that
* window doesn't get closed if CMD/CTRL W is pressed.
* Too many users have that in their muscle memory.
* Chrome doesn't let us rebind or prevent default the keybinding, so this
* at least doesn't close the window immediately.
*/
protected registerCtrlWHandling() {
function isCtrlCmd(event: KeyboardEvent) {
return (isOSX && event.metaKey) || (!isOSX && event.ctrlKey);
}

window.document.addEventListener('keydown', event => {
this.shouldPreventClose = isCtrlCmd(event) || event.code === 'KeyW';
});

window.document.addEventListener('keyup', event => {
if (isCtrlCmd(event) || event.code === 'KeyW') {
this.shouldPreventClose = false;
}
});
}

onWillStop() {
if (this.shell.canSaveAll()) {
setTimeout(() => {
this.messageService.info('Some documents should be saved, data will be lost otherwise.');
});
if (this.shouldPreventClose || this.shell.canSaveAll()) {
return true;
}
}