-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve description and correct plot for ‘auto’ correlation #1119
Conversation
3fef9e8
to
cb8b8c0
Compare
a628bed
to
629d97c
Compare
@fabclmnt the other examples are in python while this one is a Notebook. I am OK with that, and the example if fine to me but I just want to check with you that we can allow Notebooks as examples in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtook this is not a feat
it is at maximum a fix
because you included changes at the level of the correlation.py
file.
As examples are out of the package they should not be considered for version increment of the package. Can you please change the PR message in accordance?
Also, can you please confirm the license of the dataset used?
@aquemy as this is for the feature folder and not for the use-cases folder, I'll ask to have this changed to a python file. The change is minor and it eases the consumption of the code to generate automated documentation, as we have in other examples.
Notebooks should be used for examples such as usaairquality
or employees-chicago
.
14d8d3c
to
09aab0b
Compare
09aab0b
to
b698292
Compare
b698292
to
db85ab7
Compare
Codecov ReportBase: 90.95% // Head: 90.95% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #1119 +/- ##
========================================
Coverage 90.95% 90.95%
========================================
Files 179 179
Lines 5084 5084
========================================
Hits 4624 4624
Misses 460 460
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
* fix: correct plot and formatting for ‘auto’ correlation * fix: create example ‘auto’ correlation notebook * fix: add example for 'auto' correlation in python script
* fix: correct plot and formatting for ‘auto’ correlation * fix: create example ‘auto’ correlation notebook * fix: add example for 'auto' correlation in python script
* fix: correct plot and formatting for ‘auto’ correlation * fix: create example ‘auto’ correlation notebook * fix: add example for 'auto' correlation in python script
* fix: correct plot and formatting for ‘auto’ correlation * fix: create example ‘auto’ correlation notebook * fix: add example for 'auto' correlation in python script
* fix: correct plot and formatting for ‘auto’ correlation * fix: create example ‘auto’ correlation notebook * fix: add example for 'auto' correlation in python script
* fix: correct plot and formatting for ‘auto’ correlation * fix: create example ‘auto’ correlation notebook * fix: add example for 'auto' correlation in python script
* fix: correct plot and formatting for ‘auto’ correlation * fix: create example ‘auto’ correlation notebook * fix: add example for 'auto' correlation in python script
No description provided.