From a4cbb159d7550dc7b3bcd896ed24726c94ac6fcc Mon Sep 17 00:00:00 2001 From: Randy Reddig Date: Mon, 27 Sep 2021 00:22:37 -0400 Subject: [PATCH] encoding/xml: disable 3/4 tests for #43168 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I’m not sure what the right fix is for this. Malformed namespaces (leading or trailing colons, more than 1 colon) should result in an error. --- src/encoding/xml/xml_test.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/encoding/xml/xml_test.go b/src/encoding/xml/xml_test.go index 3a5f0c685d3cc7..2fdbd51cc1b4eb 100644 --- a/src/encoding/xml/xml_test.go +++ b/src/encoding/xml/xml_test.go @@ -1756,9 +1756,11 @@ func testRoundTrip(t *testing.T, input string) { func TestRoundTrip(t *testing.T) { tests := map[string]string{ - "leading colon": `<::Test ::foo="bar"><:::Hello>`, - "trailing colon": ``, - "double colon": ``, + // Disabling these tests because the parser now treats malformed namespaces as an error. + // See https://github.com/golang/go/issues/43168. + // "leading colon": `<::Test ::foo="bar"><:::Hello>`, + // "trailing colon": ``, + // "double colon": ``, "comments in directives": `--x --> > --x ]>`, } for name, input := range tests {