chore: improve contract to contract write #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+114
to
+124
| triggered_by=( | ||
| self.session.query(Transactions).filter_by(hash=triggered_by_hash).one() | ||
| if triggered_by_hash | ||
| else None | ||
| ), |
There was a problem hiding this comment.
This query is necessary since SQLAlchemy works with objects, therefore we need to have the object related here
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
=======================================
Coverage 16.32% 16.32%
=======================================
Files 111 111
Lines 7843 7843
Branches 184 184
=======================================
Hits 1280 1280
Misses 6488 6488
Partials 75 75 ☔ View full report in Codecov by Sentry. |
cristiam86
approved these changes
Oct 1, 2024
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
AgustinRamiroDiaz
force-pushed
the
agustin/chore/improve-contract-to-contract-write
branch
from
c5eed9f
to
c18ff62
Compare
|
denishacquin
approved these changes
Oct 4, 2024
cristiam86
reviewed
Oct 4, 2024
| @@ -155,4 +167,8 @@ def set_transaction_result(self, transaction_hash: str, consensus_data: dict): | |||
| transaction.status = TransactionStatus.FINALIZED | |||
| transaction.consensus_data = consensus_data | |||
|
|
|||
| self.session.commit() | |||
| print( | |||
There was a problem hiding this comment.
@AgustinRamiroDiaz wasn't this moved to the consensus? and why is there a bare print here?
| @@ -35,6 +35,11 @@ def _parse_transaction_data(transaction_data: Transactions) -> dict: | |||
| "created_at": transaction_data.created_at.isoformat(), | |||
| "leader_only": transaction_data.leader_only, | |||
| "client_session_id": transaction_data.client_session_id, | |||
| "triggered_by": transaction_data.triggered_by_hash, | |||
| "triggered_transactions": [ | |||
There was a problem hiding this comment.
@AgustinRamiroDiaz when is this field populated?
AgustinRamiroDiaz
deleted the
agustin/chore/improve-contract-to-contract-write
branch
|
🎉 This PR is included in version 0.13.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of #454
What
Adds self relationship to
Transactionsto be able to track the triggered transactionsI'll try adding more tests through the day if I have time
Why
Testing done
Decisions made
In the UI it's just plain text
We could improve this maybe by polling the
triggered_transactions. But those transactions could trigger even more transactions, so this needs a bit more of definition prior to working on itChecks
Reviewing tips
User facing release notes
You can now see the transactions triggered by your Intelligen Contract when writing to other contracts