Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct ArchGDAL. IFeatureLayer via named tuples or DataFrame #152

Open
zerefwayne opened this issue Nov 9, 2020 · 5 comments · May be fixed by #243
Open

Construct ArchGDAL. IFeatureLayer via named tuples or DataFrame #152

zerefwayne opened this issue Nov 9, 2020 · 5 comments · May be fixed by #243
Assignees
Milestone

Comments

@zerefwayne
Copy link
Contributor

zerefwayne commented Nov 9, 2020

I have a use case of filtering rows out of an ArchGDAL table and then return ArchGDAL.Table datatype. It would be helpful to construct an ArchGDAL.Table using an array of named tuples or even a DataFrame from DataFrames.jl.

struct Table{T<:Union{IFeatureLayer, FeatureLayer}}
layer::T
end

cc: @juliohm @visr

@juliohm
Copy link

juliohm commented Nov 9, 2020

@zerefwayne I suggest starting a draft PR in GADM.jl and linking to this issue. It is hard to know exactly what you are trying to achieve otherwise. 👍

@yeesian
Copy link
Owner

yeesian commented Nov 15, 2020

We currently support https://tables.juliadata.org/stable/#Implementing-the-Interface-(i.e.-becoming-a-Tables.jl-source)-1 in src/tables.jl.

It will be nice to support the creation of an ArchGDAL.Dataset (or FeatureLayer) from a corresponding table via https://tables.juliadata.org/stable/#Using-the-Interface-(i.e.-consuming-Tables.jl-compatible-sources)-1: here's an example of how it can be done. Here's a second example: https://discourse.julialang.org/t/how-to-create-a-new-shapefile-containing-a-few-points.

@evetion
Copy link
Collaborator

evetion commented Dec 30, 2020

Shameless plug (I'm the author), I've made a first implementation over at https://github.com/evetion/GeoDataFrames.jl.

@yeesian yeesian added this to the v1.0 milestone May 15, 2021
@mathieu17g
Copy link
Collaborator

@yeesian (cc: @evetion) I'm could work on this by creating IFeatureLayer constructor for table types (creating an associated a "Memory" driver Dataset).

Writing to a file, could then be handled by a write, leaving GDAL handling the driver restrictions as pointed in #147 (comment)

@yeesian yeesian changed the title Construct ArchGDAL.Table via named tuples or DataFrame Construct ArchGDAL. IFeatureLayer via named tuples or DataFrame Sep 3, 2021
@yeesian
Copy link
Owner

yeesian commented Sep 3, 2021

That'll be really awesome @mathieu17g! I also agree that the analogous GDAL object is a feature layer and have updated the title to reflect it.

Somewhat related: #153

@mathieu17g mathieu17g linked a pull request Sep 8, 2021 that will close this issue
10 tasks
@yeesian yeesian linked a pull request Oct 8, 2021 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants