Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArchGDAL.Table not defined in v0.7 #210

Closed
juliohm opened this issue Jun 29, 2021 · 4 comments
Closed

ArchGDAL.Table not defined in v0.7 #210

juliohm opened this issue Jun 29, 2021 · 4 comments

Comments

@juliohm
Copy link

juliohm commented Jun 29, 2021

I am trying to update downstream packages but they are complaining that ArchGDAL.Table doesn't exist. The latest stable documentation says it should exist still. Could you please help identify the issue?

@visr
Copy link
Collaborator

visr commented Jun 29, 2021

Hmm, it seems the stable docs have not been updated since January, so something is wrong there.
Dev docs are updated however: https://yeesian.com/ArchGDAL.jl/dev/tables/

ArchGDAL.Table was not needed anymore, since we could just implement the Tables interface directly on AbstractFeatureLayer.

So this:
https://github.com/JuliaEarth/GeoTables.jl/blob/79c9ffb22724cde58f51dfbb77a48ebaedbf0048/src/GeoTables.jl#L37-L38

can be condensed to table = AG.getlayer(file, layer).

@juliohm
Copy link
Author

juliohm commented Jun 29, 2021

Thanks, I am trying to update GADM.jl here: https://github.com/JuliaGeo/GADM.jl/blob/f04d7c2d4c63ac9ffa14927b5f1404ae8f2a98c3/src/GADM.jl#L108

I understand that in the new version the layer is already a table so I replaced the line table = ArchGDAL.Table(layer) with table = layer. There are other errors popping up now. Is there a list of breaking changes and recommendations to update the code?

@visr
Copy link
Collaborator

visr commented Jun 29, 2021

The top post of #179 has a list of breaking changes. I just added a note about Table to it, since that was added later.

@yeesian
Copy link
Owner

yeesian commented Jul 5, 2021

Fixed by 6b545fa.

@yeesian yeesian closed this as completed Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants