Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omnifunc is not set when LspOptionsSet is called after LspAddServer #532

Open
nv-quan opened this issue Jun 16, 2024 · 1 comment
Open

Comments

@nv-quan
Copy link
Contributor

nv-quan commented Jun 16, 2024

The documentation states that setting autoComplete to false will automatically set omniComplete to true, and omnifunc will be set. However, this does not work as expected when LspOptionsSet is called after LspAddServer. The documentation should clarify the required order of calling LspOptionsSet and LspAddServer. Alternatively, the code should ensure omniComplete is set correctly after LspOptionsSet is called, or even better, refactor LspAddServer to accept LSP options as an argument.

@nv-quan nv-quan changed the title omniComplete is not set to true when LspOptionsSet is called after LspAddServer omnifunc is not set when LspOptionsSet is called after LspAddServer Jun 17, 2024
@Konfekt
Copy link
Contributor

Konfekt commented Jun 18, 2024

This was discussed already a couple of times, say in https://github.com/yegappan/lsp/pull/442/files and e3216ca, and 87189fa ;
the doc now states the correct order of calling LspOptionsSet and LspAddServer.
However, I'd agree that it would make users' life simpler if the importance of this order was drawn to attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants