Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for Bower installation path #41

Open
ain opened this issue Jul 14, 2016 · 2 comments
Open

Option for Bower installation path #41

ain opened this issue Jul 14, 2016 · 2 comments

Comments

@ain
Copy link

ain commented Jul 14, 2016

Currently all paths, e.g. ../bower_components/mocha/mocha.css are hard-coded and assume that Bower components reside at root level. In some cases though, this is not desired.

I'd suggest making paths dynamic with an option that would allow modifying Bower path.

Alternatively one could also identify if there's ../.bowerrc and fetch the path from there.

@SBoudrias
Copy link
Member

Alternatively one could also identify if there's ../.bowerrc and fetch the path from there.

That's totally what we should do (but with bower.json). Using find-up, it should be fairly simple to locate the bower.json file and use it as the root where bower_components is located.

@ain any chance you're be willing to send a PR?

@ain
Copy link
Author

ain commented Jul 14, 2016

Thanks for prompt feedback.

An important consideration though: bower.json location is not sufficient as one could go with .bowerrc with

{
  "directory": "app/bower_components"
}

next to bower.json. So it's slightly more complex.

I'm a bit overwhelmed currently, but PR would eventually be doable of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants