Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Monorepo with multiple remix projects $path is typed for the last built project #20

Closed
Rocinante89 opened this issue Oct 12, 2022 · 5 comments · Fixed by #21
Closed

In Monorepo with multiple remix projects $path is typed for the last built project #20

Rocinante89 opened this issue Oct 12, 2022 · 5 comments · Fixed by #21
Labels
released

Comments

@Rocinante89
Copy link

Not sure if this is something you want to put the work into fixing - But we have a monorepo with 2 remix projects, both using remix-routes.

We noticed that the routes on $path reflect the last built project, not matter which project it has been called from. I think it's because the types are generated at the root level. I'll try and get a repo ready after work
@yesmeck
Copy link
Owner

yesmeck commented Oct 12, 2022

I think it's a bug, I didn't take into account having more than one remix project in a monorepo.

@yesmeck
Copy link
Owner

yesmeck commented Oct 14, 2022

Can not find a solution to fix this issue. It seems prisma client has the same issue.

@yesmeck
Copy link
Owner

yesmeck commented Oct 14, 2022

Got some ideas in my head, will try to fix this issue tomorrow.

@Rocinante89
Copy link
Author

Cheers! It's easily enough worked around at any rate. We just have to run a new build command when switching what project we are working on

yesmeck added a commit that referenced this issue Oct 16, 2022
@yesmeck
fix: support multiple remix projects in one monorepo
b03e4d1 
close #20
@yesmeck yesmeck mentioned this issue Oct 16, 2022
Merged
yesmeck added a commit that referenced this issue Oct 16, 2022
@yesmeck
fix: support multiple remix projects in one monorepo
738f2be 
close #20
yesmeck added a commit that referenced this issue Oct 16, 2022
@yesmeck
fix: support multiple remix projects in one monorepo
4d6da77 
close #20
yesmeck added a commit that referenced this issue Oct 16, 2022
@yesmeck
fix: support multiple remix projects in one monorepo
ab76af9 
close #20
yesmeck added a commit that referenced this issue Oct 16, 2022
@yesmeck
fix: support multiple remix projects in one monorepo
e8c824d 
close #20
yesmeck added a commit that referenced this issue Oct 16, 2022
@yesmeck
fix: support multiple remix projects in one monorepo (#21)
9cb47cf 
* fix: support multiple remix projects in one monorepo

close #20

* chore: bump version

* chore: bump version
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 0.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@yesmeck yesmeck mentioned this issue Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support multiple remix projects in one monorepo yesmeck/safe-routes
2 participants
@yesmeck @Rocinante89