From 5f988663418be5b75a3bc2decf1baae063edf363 Mon Sep 17 00:00:00 2001
From: Kaede Hoshikawa <futursolo@icloud.com>
Date: Wed, 6 Oct 2021 19:16:01 +0900
Subject: [PATCH 1/8] Add Redirect Comp.

---
 packages/yew-router/src/components/mod.rs     |  2 ++
 .../yew-router/src/components/redirect.rs     | 32 +++++++++++++++++++
 packages/yew-router/src/lib.rs                |  2 +-
 3 files changed, 35 insertions(+), 1 deletion(-)
 create mode 100644 packages/yew-router/src/components/redirect.rs

diff --git a/packages/yew-router/src/components/mod.rs b/packages/yew-router/src/components/mod.rs
index b6808da2757..bcec0215fb9 100644
--- a/packages/yew-router/src/components/mod.rs
+++ b/packages/yew-router/src/components/mod.rs
@@ -1,4 +1,6 @@
 //! Components to interface with [Router][crate::Router].
 
 mod link;
+mod redirect;
 pub use link::*;
+pub use redirect::*;
diff --git a/packages/yew-router/src/components/redirect.rs b/packages/yew-router/src/components/redirect.rs
new file mode 100644
index 00000000000..1e3b46a7abb
--- /dev/null
+++ b/packages/yew-router/src/components/redirect.rs
@@ -0,0 +1,32 @@
+use crate::{service, Routable};
+use std::marker::PhantomData;
+use yew::prelude::*;
+
+/// Props for [`Link`]
+#[derive(Properties, Clone, PartialEq)]
+pub struct RedirectProps<R: Routable + Clone + PartialEq> {
+    /// Route that will be pushed when the component is rendered.
+    pub to: R,
+}
+
+/// A component that will redirect to specified route when rendered.
+pub struct Redirect<R: Routable + Clone + PartialEq + 'static> {
+    _data: PhantomData<R>,
+}
+
+impl<R> Component for Redirect<R>
+where
+    R: Routable + Clone + PartialEq + 'static,
+{
+    type Message = ();
+    type Properties = RedirectProps<R>;
+
+    fn create(_ctx: &Context<Self>) -> Self {
+        Self { _data: PhantomData }
+    }
+
+    fn view(&self, ctx: &Context<Self>) -> Html {
+        service::push_route(ctx.props().to.clone());
+        Html::default()
+    }
+}
diff --git a/packages/yew-router/src/lib.rs b/packages/yew-router/src/lib.rs
index 80d64dac708..97245e4673d 100644
--- a/packages/yew-router/src/lib.rs
+++ b/packages/yew-router/src/lib.rs
@@ -74,7 +74,7 @@ pub mod prelude {
     //!
     //! This module re-exports the frequently used types from the crate.
 
-    pub use crate::components::Link;
+    pub use crate::components::{Link, Redirect};
     #[doc(no_inline)]
     pub use crate::Routable;
     pub use crate::Router;

From d2935af6a9b7407513c7698ced56a2a758e8fb15 Mon Sep 17 00:00:00 2001
From: Kaede Hoshikawa <futursolo@icloud.com>
Date: Sat, 9 Oct 2021 13:50:10 +0900
Subject: [PATCH 2/8] Fix router behaviour.

---
 packages/yew-router/src/macro_helpers.rs      | 21 ++++----
 .../yew-router/tests/router_unit_tests.rs     | 50 +++++++++++++++++++
 2 files changed, 61 insertions(+), 10 deletions(-)
 create mode 100644 packages/yew-router/tests/router_unit_tests.rs

diff --git a/packages/yew-router/src/macro_helpers.rs b/packages/yew-router/src/macro_helpers.rs
index e29cc0dc874..ede9a9b4851 100644
--- a/packages/yew-router/src/macro_helpers.rs
+++ b/packages/yew-router/src/macro_helpers.rs
@@ -1,3 +1,5 @@
+use std::borrow::Cow;
+
 use crate::utils::{base_url, strip_slash_suffix};
 use crate::Routable;
 
@@ -9,16 +11,14 @@ pub fn build_router<R: Routable>() -> Router {
     let base = base_url();
     let mut router = Router::new();
     R::routes().iter().for_each(|path| {
-        match &base {
-            Some(base) => {
-                let route = format!("{}{}", base, path);
-                let route = strip_slash_suffix(&route);
-                router.add(route, path.to_string());
-            }
-            _ => {
-                router.add(path, path.to_string());
-            }
+        let route = match base {
+            Some(ref base) => Cow::from(format!("{}{}", base, path)),
+            _ => (*path).into(),
         };
+
+        let stripped_route = strip_slash_suffix(&route);
+
+        router.add(stripped_route, path.to_string());
     });
 
     router
@@ -30,7 +30,8 @@ pub fn recognize_with_router<R: Routable>(router: &Router, pathname: &str) -> Op
     let matched = router.recognize(pathname);
 
     match matched {
-        Ok(matched) => R::from_path(matched.handler(), &matched.params().into_iter().collect()),
+        Ok(matched) => R::from_path(matched.handler(), &matched.params().into_iter().collect())
+            .or_else(R::not_found_route),
         Err(_) => R::not_found_route(),
     }
 }
diff --git a/packages/yew-router/tests/router_unit_tests.rs b/packages/yew-router/tests/router_unit_tests.rs
new file mode 100644
index 00000000000..869060643eb
--- /dev/null
+++ b/packages/yew-router/tests/router_unit_tests.rs
@@ -0,0 +1,50 @@
+use wasm_bindgen_test::{wasm_bindgen_test as test, wasm_bindgen_test_configure};
+use yew_router::prelude::*;
+
+wasm_bindgen_test_configure!(run_in_browser);
+
+#[test]
+fn router_always_404() {
+    #[derive(Routable, Debug, Clone, PartialEq)]
+    enum AppRoute {
+        #[at("/")]
+        Home,
+        #[at("/:id")]
+        Article { id: u64 },
+        #[at("/404")]
+        #[not_found]
+        NotFound,
+    }
+
+    assert_eq!(
+        Some(AppRoute::NotFound),
+        AppRoute::recognize("/not/matched/route")
+    );
+    assert_eq!(
+        Some(AppRoute::NotFound),
+        AppRoute::recognize("/not-matched-route")
+    );
+}
+
+#[test]
+fn router_trailing_slash() {
+    #[derive(Routable, Debug, Clone, PartialEq)]
+    enum AppRoute {
+        #[at("/")]
+        Home,
+        #[at("/category/:name/")]
+        Category { name: String },
+        #[at("/:id")]
+        Article { id: u64 },
+        #[at("/404")]
+        #[not_found]
+        NotFound,
+    }
+
+    assert_eq!(
+        Some(AppRoute::Category {
+            name: "cooking-recipes".to_string()
+        }),
+        AppRoute::recognize("/category/cooking-recipes/")
+    );
+}

From 02d1bd5bbe1f6d89987d1446dd4279b77243701c Mon Sep 17 00:00:00 2001
From: Kaede Hoshikawa <futursolo@icloud.com>
Date: Sat, 9 Oct 2021 14:22:31 +0900
Subject: [PATCH 3/8] Fix output.

---
 .../tests/html_macro/element-fail.stderr      | 110 +++++++++---------
 .../yew-router/src/components/redirect.rs     |   2 +-
 packages/yew-router/src/macro_helpers.rs      |   2 +-
 3 files changed, 57 insertions(+), 57 deletions(-)

diff --git a/packages/yew-macro/tests/html_macro/element-fail.stderr b/packages/yew-macro/tests/html_macro/element-fail.stderr
index a69e3e4958e..1353c0b9328 100644
--- a/packages/yew-macro/tests/html_macro/element-fail.stderr
+++ b/packages/yew-macro/tests/html_macro/element-fail.stderr
@@ -1,209 +1,209 @@
 error: this opening tag has no corresponding closing tag
- --> $DIR/tests/html_macro/element-fail.rs:7:13
+ --> $DIR/element-fail.rs:7:13
   |
 7 |     html! { <div> };
   |             ^^^^^
 
 error: this opening tag has no corresponding closing tag
- --> $DIR/tests/html_macro/element-fail.rs:8:18
+ --> $DIR/element-fail.rs:8:18
   |
 8 |     html! { <div><div> };
   |                  ^^^^^
 
 error: this opening tag has no corresponding closing tag
- --> $DIR/tests/html_macro/element-fail.rs:9:13
+ --> $DIR/element-fail.rs:9:13
   |
 9 |     html! { <div><div></div> };
   |             ^^^^^
 
 error: this closing tag has no corresponding opening tag
-  --> $DIR/tests/html_macro/element-fail.rs:12:13
+  --> $DIR/element-fail.rs:12:13
    |
 12 |     html! { </div> };
    |             ^^^^^^
 
 error: this closing tag has no corresponding opening tag
-  --> $DIR/tests/html_macro/element-fail.rs:13:18
+  --> $DIR/element-fail.rs:13:18
    |
 13 |     html! { <div></span></div> };
    |                  ^^^^^^^
 
 error: only one root html element is allowed (hint: you can wrap multiple html elements in a fragment `<></>`)
-  --> $DIR/tests/html_macro/element-fail.rs:14:20
+  --> $DIR/element-fail.rs:14:20
    |
 14 |     html! { <img /></img> };
    |                    ^^^^^^
 
 error: this closing tag has no corresponding opening tag
-  --> $DIR/tests/html_macro/element-fail.rs:17:18
+  --> $DIR/element-fail.rs:17:18
    |
 17 |     html! { <div></span> };
    |                  ^^^^^^^
 
 error: this closing tag has no corresponding opening tag
-  --> $DIR/tests/html_macro/element-fail.rs:18:20
+  --> $DIR/element-fail.rs:18:20
    |
 18 |     html! { <tag-a></tag-b> };
    |                    ^^^^^^^^
 
 error: only one root html element is allowed (hint: you can wrap multiple html elements in a fragment `<></>`)
-  --> $DIR/tests/html_macro/element-fail.rs:21:24
+  --> $DIR/element-fail.rs:21:24
    |
 21 |     html! { <div></div><div></div> };
    |                        ^^^^^^^^^^^
 
 error: expected a valid html element
-  --> $DIR/tests/html_macro/element-fail.rs:23:18
+  --> $DIR/element-fail.rs:23:18
    |
 23 |     html! { <div>Invalid</div> };
    |                  ^^^^^^^
 
 error: `attr` can only be specified once but is given here again
-  --> $DIR/tests/html_macro/element-fail.rs:26:27
+  --> $DIR/element-fail.rs:26:27
    |
 26 |     html! { <input attr=1 attr=2 /> };
    |                           ^^^^
 
 error: `value` can only be specified once but is given here again
-  --> $DIR/tests/html_macro/element-fail.rs:27:32
+  --> $DIR/element-fail.rs:27:32
    |
 27 |     html! { <input value="123" value="456" /> };
    |                                ^^^^^
 
 error: `kind` can only be specified once but is given here again
-  --> $DIR/tests/html_macro/element-fail.rs:28:36
+  --> $DIR/element-fail.rs:28:36
    |
 28 |     html! { <input kind="checkbox" kind="submit" /> };
    |                                    ^^^^
 
 error: `checked` can only be specified once but is given here again
-  --> $DIR/tests/html_macro/element-fail.rs:29:33
+  --> $DIR/element-fail.rs:29:33
    |
 29 |     html! { <input checked=true checked=false /> };
    |                                 ^^^^^^^
 
 error: `disabled` can only be specified once but is given here again
-  --> $DIR/tests/html_macro/element-fail.rs:30:34
+  --> $DIR/element-fail.rs:30:34
    |
 30 |     html! { <input disabled=true disabled=false /> };
    |                                  ^^^^^^^^
 
 error: `selected` can only be specified once but is given here again
-  --> $DIR/tests/html_macro/element-fail.rs:31:35
+  --> $DIR/element-fail.rs:31:35
    |
 31 |     html! { <option selected=true selected=false /> };
    |                                   ^^^^^^^^
 
 error: `class` can only be specified once but is given here again
-  --> $DIR/tests/html_macro/element-fail.rs:32:32
+  --> $DIR/element-fail.rs:32:32
    |
 32 |     html! { <div class="first" class="second" /> };
    |                                ^^^^^
 
 error: `ref` can only be specified once
-  --> $DIR/tests/html_macro/element-fail.rs:33:20
+  --> $DIR/element-fail.rs:33:20
    |
 33 |     html! { <input ref={()} ref={()} /> };
    |                    ^^^
 
 error: `ref` can only be specified once
-  --> $DIR/tests/html_macro/element-fail.rs:63:20
+  --> $DIR/element-fail.rs:63:20
    |
 63 |     html! { <input ref={()} ref={()} /> };
    |                    ^^^
 
 error: the tag `<input>` is a void element and cannot have children (hint: rewrite this as `<input/>`)
-  --> $DIR/tests/html_macro/element-fail.rs:66:13
+  --> $DIR/element-fail.rs:66:13
    |
 66 |     html! { <input type="text"></input> };
    |             ^^^^^^^^^^^^^^^^^^^
 
 error: the tag `<iNpUt>` is a void element and cannot have children (hint: rewrite this as `<iNpUt/>`)
-  --> $DIR/tests/html_macro/element-fail.rs:68:13
+  --> $DIR/element-fail.rs:68:13
    |
 68 |     html! { <iNpUt type="text"></iNpUt> };
    |             ^^^^^^^^^^^^^^^^^^^
 
 error: this dynamic tag is missing an expression block defining its value
-  --> $DIR/tests/html_macro/element-fail.rs:71:14
+  --> $DIR/element-fail.rs:71:14
    |
 71 |     html! { <@></@> };
    |              ^
 
 error: this dynamic tag is missing an expression block defining its value
-  --> $DIR/tests/html_macro/element-fail.rs:72:14
+  --> $DIR/element-fail.rs:72:14
    |
 72 |     html! { <@/> };
    |              ^
 
 error: dynamic closing tags must not have a body (hint: replace it with just `</@>`)
-  --> $DIR/tests/html_macro/element-fail.rs:75:27
+  --> $DIR/element-fail.rs:75:27
    |
 75 |     html! { <@{"test"}></@{"test"}> };
    |                           ^^^^^^^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/tests/html_macro/element-fail.rs:83:24
+  --> $DIR/element-fail.rs:83:24
    |
 83 |     html! { <div class=("deprecated", "warning") /> };
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/tests/html_macro/element-fail.rs:84:24
+  --> $DIR/element-fail.rs:84:24
    |
 84 |     html! { <input ref=() /> };
    |                        ^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/tests/html_macro/element-fail.rs:85:24
+  --> $DIR/element-fail.rs:85:24
    |
 85 |     html! { <input ref=() ref=() /> };
    |                        ^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/tests/html_macro/element-fail.rs:86:28
+  --> $DIR/element-fail.rs:86:28
    |
 86 |     html! { <input onfocus=Some(5) /> };
    |                            ^^^^^^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/tests/html_macro/element-fail.rs:87:27
+  --> $DIR/element-fail.rs:87:27
    |
 87 |     html! { <input string=NotToString /> };
    |                           ^^^^^^^^^^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/tests/html_macro/element-fail.rs:88:22
+  --> $DIR/element-fail.rs:88:22
    |
 88 |     html! { <a media=Some(NotToString) /> };
    |                      ^^^^^^^^^^^^^^^^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/tests/html_macro/element-fail.rs:89:21
+  --> $DIR/element-fail.rs:89:21
    |
 89 |     html! { <a href=Some(5) /> };
    |                     ^^^^^^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/tests/html_macro/element-fail.rs:90:25
+  --> $DIR/element-fail.rs:90:25
    |
 90 |     html! { <input type=() /> };
    |                         ^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/tests/html_macro/element-fail.rs:91:26
+  --> $DIR/element-fail.rs:91:26
    |
 91 |     html! { <input value=() /> };
    |                          ^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/tests/html_macro/element-fail.rs:92:27
+  --> $DIR/element-fail.rs:92:27
    |
 92 |     html! { <input string=NotToString /> };
    |                           ^^^^^^^^^^^
 
 warning: use of deprecated function `compile_fail::deprecated_use_of_class`: the use of `(...)` with the attribute `class` is deprecated and will be removed in version 0.19. Use the `classes!` macro instead.
-  --> $DIR/tests/html_macro/element-fail.rs:80:25
+  --> $DIR/element-fail.rs:80:25
    |
 80 |     html! { <div class={("deprecated", "warning")} /> };
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -211,13 +211,13 @@ warning: use of deprecated function `compile_fail::deprecated_use_of_class`: the
    = note: `#[warn(deprecated)]` on by default
 
 error[E0308]: mismatched types
-  --> $DIR/tests/html_macro/element-fail.rs:36:28
+  --> $DIR/element-fail.rs:36:28
    |
 36 |     html! { <input checked=1 /> };
    |                            ^ expected `bool`, found integer
 
 error[E0308]: mismatched types
-  --> $DIR/tests/html_macro/element-fail.rs:37:29
+  --> $DIR/element-fail.rs:37:29
    |
 37 |     html! { <input checked={Some(false)} /> };
    |                             ^^^^^^^^^^^ expected `bool`, found enum `Option`
@@ -226,13 +226,13 @@ error[E0308]: mismatched types
               found enum `Option<bool>`
 
 error[E0308]: mismatched types
-  --> $DIR/tests/html_macro/element-fail.rs:38:29
+  --> $DIR/element-fail.rs:38:29
    |
 38 |     html! { <input disabled=1 /> };
    |                             ^ expected `bool`, found integer
 
 error[E0308]: mismatched types
-  --> $DIR/tests/html_macro/element-fail.rs:39:30
+  --> $DIR/element-fail.rs:39:30
    |
 39 |     html! { <input disabled={Some(true)} /> };
    |                              ^^^^^^^^^^ expected `bool`, found enum `Option`
@@ -241,13 +241,13 @@ error[E0308]: mismatched types
               found enum `Option<bool>`
 
 error[E0308]: mismatched types
-  --> $DIR/tests/html_macro/element-fail.rs:40:30
+  --> $DIR/element-fail.rs:40:30
    |
 40 |     html! { <option selected=1 /> };
    |                              ^ expected `bool`, found integer
 
 error[E0277]: the trait bound `(): IntoPropValue<Option<Cow<'static, str>>>` is not satisfied
-  --> $DIR/tests/html_macro/element-fail.rs:43:26
+  --> $DIR/element-fail.rs:43:26
    |
 43 |     html! { <input type={()} /> };
    |                          ^^ the trait `IntoPropValue<Option<Cow<'static, str>>>` is not implemented for `()`
@@ -255,7 +255,7 @@ error[E0277]: the trait bound `(): IntoPropValue<Option<Cow<'static, str>>>` is
    = note: required by `into_prop_value`
 
 error[E0277]: the trait bound `(): IntoPropValue<Option<Cow<'static, str>>>` is not satisfied
-  --> $DIR/tests/html_macro/element-fail.rs:44:27
+  --> $DIR/element-fail.rs:44:27
    |
 44 |     html! { <input value={()} /> };
    |                           ^^ the trait `IntoPropValue<Option<Cow<'static, str>>>` is not implemented for `()`
@@ -263,7 +263,7 @@ error[E0277]: the trait bound `(): IntoPropValue<Option<Cow<'static, str>>>` is
    = note: required by `into_prop_value`
 
 error[E0277]: the trait bound `(): IntoPropValue<Option<Cow<'static, str>>>` is not satisfied
-  --> $DIR/tests/html_macro/element-fail.rs:45:22
+  --> $DIR/element-fail.rs:45:22
    |
 45 |     html! { <a href={()} /> };
    |                      ^^ the trait `IntoPropValue<Option<Cow<'static, str>>>` is not implemented for `()`
@@ -271,7 +271,7 @@ error[E0277]: the trait bound `(): IntoPropValue<Option<Cow<'static, str>>>` is
    = note: required by `into_prop_value`
 
 error[E0277]: the trait bound `NotToString: IntoPropValue<Option<Cow<'static, str>>>` is not satisfied
-  --> $DIR/tests/html_macro/element-fail.rs:46:28
+  --> $DIR/element-fail.rs:46:28
    |
 46 |     html! { <input string={NotToString} /> };
    |                            ^^^^^^^^^^^ the trait `IntoPropValue<Option<Cow<'static, str>>>` is not implemented for `NotToString`
@@ -279,7 +279,7 @@ error[E0277]: the trait bound `NotToString: IntoPropValue<Option<Cow<'static, st
    = note: required by `into_prop_value`
 
 error[E0277]: the trait bound `Option<NotToString>: IntoPropValue<Option<Cow<'static, str>>>` is not satisfied
-  --> $DIR/tests/html_macro/element-fail.rs:47:23
+  --> $DIR/element-fail.rs:47:23
    |
 47 |     html! { <a media={Some(NotToString)} /> };
    |                       ^^^^^^^^^^^^^^^^^ the trait `IntoPropValue<Option<Cow<'static, str>>>` is not implemented for `Option<NotToString>`
@@ -291,7 +291,7 @@ error[E0277]: the trait bound `Option<NotToString>: IntoPropValue<Option<Cow<'st
    = note: required by `into_prop_value`
 
 error[E0277]: the trait bound `Option<{integer}>: IntoPropValue<Option<Cow<'static, str>>>` is not satisfied
-  --> $DIR/tests/html_macro/element-fail.rs:48:22
+  --> $DIR/element-fail.rs:48:22
    |
 48 |     html! { <a href={Some(5)} /> };
    |                      ^^^^^^^ the trait `IntoPropValue<Option<Cow<'static, str>>>` is not implemented for `Option<{integer}>`
@@ -303,7 +303,7 @@ error[E0277]: the trait bound `Option<{integer}>: IntoPropValue<Option<Cow<'stat
    = note: required by `into_prop_value`
 
 error[E0277]: expected a `Fn<(MouseEvent,)>` closure, found `{integer}`
-   --> $DIR/tests/html_macro/element-fail.rs:51:28
+   --> $DIR/element-fail.rs:51:28
     |
 51  |       html! { <input onclick=1 /> };
     |                              ^ expected an `Fn<(MouseEvent,)>` closure, found `{integer}`
@@ -323,7 +323,7 @@ error[E0277]: expected a `Fn<(MouseEvent,)>` closure, found `{integer}`
     = note: required because of the requirements on the impl of `IntoEventCallback<MouseEvent>` for `{integer}`
 
 error[E0277]: expected a `Fn<(MouseEvent,)>` closure, found `yew::Callback<String>`
-   --> $DIR/tests/html_macro/element-fail.rs:52:29
+   --> $DIR/element-fail.rs:52:29
     |
 52  |       html! { <input onclick={Callback::from(|a: String| ())} /> };
     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -346,7 +346,7 @@ error[E0277]: expected a `Fn<(MouseEvent,)>` closure, found `yew::Callback<Strin
     = note: required because of the requirements on the impl of `IntoEventCallback<MouseEvent>` for `yew::Callback<String>`
 
 error[E0277]: the trait bound `Option<{integer}>: IntoEventCallback<FocusEvent>` is not satisfied
-   --> $DIR/tests/html_macro/element-fail.rs:53:29
+   --> $DIR/element-fail.rs:53:29
     |
 53  |       html! { <input onfocus={Some(5)} /> };
     |                               ^^^^^^^ the trait `IntoEventCallback<FocusEvent>` is not implemented for `Option<{integer}>`
@@ -367,7 +367,7 @@ error[E0277]: the trait bound `Option<{integer}>: IntoEventCallback<FocusEvent>`
               <Option<yew::Callback<EVENT>> as IntoEventCallback<EVENT>>
 
 error[E0277]: the trait bound `(): IntoPropValue<yew::NodeRef>` is not satisfied
-  --> $DIR/tests/html_macro/element-fail.rs:56:25
+  --> $DIR/element-fail.rs:56:25
    |
 56 |     html! { <input ref={()} /> };
    |                         ^^ the trait `IntoPropValue<yew::NodeRef>` is not implemented for `()`
@@ -375,7 +375,7 @@ error[E0277]: the trait bound `(): IntoPropValue<yew::NodeRef>` is not satisfied
    = note: required by `into_prop_value`
 
 error[E0277]: the trait bound `Option<yew::NodeRef>: IntoPropValue<yew::NodeRef>` is not satisfied
-  --> $DIR/tests/html_macro/element-fail.rs:57:25
+  --> $DIR/element-fail.rs:57:25
    |
 57 |     html! { <input ref={Some(NodeRef::default())} /> };
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^ the trait `IntoPropValue<yew::NodeRef>` is not implemented for `Option<yew::NodeRef>`
@@ -387,7 +387,7 @@ error[E0277]: the trait bound `Option<yew::NodeRef>: IntoPropValue<yew::NodeRef>
    = note: required by `into_prop_value`
 
 error[E0277]: expected a `Fn<(MouseEvent,)>` closure, found `yew::Callback<String>`
-   --> $DIR/tests/html_macro/element-fail.rs:58:29
+   --> $DIR/element-fail.rs:58:29
     |
 58  |       html! { <input onclick={Callback::from(|a: String| ())} /> };
     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -410,7 +410,7 @@ error[E0277]: expected a `Fn<(MouseEvent,)>` closure, found `yew::Callback<Strin
     = note: required because of the requirements on the impl of `IntoEventCallback<MouseEvent>` for `yew::Callback<String>`
 
 error[E0277]: the trait bound `NotToString: IntoPropValue<Option<Cow<'static, str>>>` is not satisfied
-  --> $DIR/tests/html_macro/element-fail.rs:60:28
+  --> $DIR/element-fail.rs:60:28
    |
 60 |     html! { <input string={NotToString} /> };
    |                            ^^^^^^^^^^^ the trait `IntoPropValue<Option<Cow<'static, str>>>` is not implemented for `NotToString`
@@ -418,7 +418,7 @@ error[E0277]: the trait bound `NotToString: IntoPropValue<Option<Cow<'static, st
    = note: required by `into_prop_value`
 
 error[E0277]: the trait bound `(): IntoPropValue<yew::NodeRef>` is not satisfied
-  --> $DIR/tests/html_macro/element-fail.rs:62:25
+  --> $DIR/element-fail.rs:62:25
    |
 62 |     html! { <input ref={()} /> };
    |                         ^^ the trait `IntoPropValue<yew::NodeRef>` is not implemented for `()`
@@ -426,7 +426,7 @@ error[E0277]: the trait bound `(): IntoPropValue<yew::NodeRef>` is not satisfied
    = note: required by `into_prop_value`
 
 error[E0277]: the trait bound `Cow<'static, str>: From<{integer}>` is not satisfied
-  --> $DIR/tests/html_macro/element-fail.rs:77:15
+  --> $DIR/element-fail.rs:77:15
    |
 77 |     html! { <@{55}></@> };
    |               ^^^^ the trait `From<{integer}>` is not implemented for `Cow<'static, str>`
diff --git a/packages/yew-router/src/components/redirect.rs b/packages/yew-router/src/components/redirect.rs
index 1e3b46a7abb..a8b31e7ec21 100644
--- a/packages/yew-router/src/components/redirect.rs
+++ b/packages/yew-router/src/components/redirect.rs
@@ -2,7 +2,7 @@ use crate::{service, Routable};
 use std::marker::PhantomData;
 use yew::prelude::*;
 
-/// Props for [`Link`]
+/// Props for [`Redirect`]
 #[derive(Properties, Clone, PartialEq)]
 pub struct RedirectProps<R: Routable + Clone + PartialEq> {
     /// Route that will be pushed when the component is rendered.
diff --git a/packages/yew-router/src/macro_helpers.rs b/packages/yew-router/src/macro_helpers.rs
index ede9a9b4851..9e136d9655e 100644
--- a/packages/yew-router/src/macro_helpers.rs
+++ b/packages/yew-router/src/macro_helpers.rs
@@ -13,7 +13,7 @@ pub fn build_router<R: Routable>() -> Router {
     R::routes().iter().for_each(|path| {
         let route = match base {
             Some(ref base) => Cow::from(format!("{}{}", base, path)),
-            _ => (*path).into(),
+            None => (*path).into(),
         };
 
         let stripped_route = strip_slash_suffix(&route);

From 114672d37d0702309eeab8e5905471e8f54f11f8 Mon Sep 17 00:00:00 2001
From: Kaede Hoshikawa <futursolo@icloud.com>
Date: Sat, 9 Oct 2021 14:31:23 +0900
Subject: [PATCH 4/8] Fix pr-flow.

---
 .../tests/html_macro/element-fail.stderr      | 40 +++++++++----------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/packages/yew-macro/tests/html_macro/element-fail.stderr b/packages/yew-macro/tests/html_macro/element-fail.stderr
index 1353c0b9328..4ce990ed9e8 100644
--- a/packages/yew-macro/tests/html_macro/element-fail.stderr
+++ b/packages/yew-macro/tests/html_macro/element-fail.stderr
@@ -311,12 +311,12 @@ error[E0277]: expected a `Fn<(MouseEvent,)>` closure, found `{integer}`
    ::: $WORKSPACE/packages/yew/src/html/listener/events.rs
     |
     | / impl_short! {
-    | |     onauxclick(MouseEvent)
-    | |     onclick(MouseEvent)
-    | |
+133 | |     onauxclick(MouseEvent)
+134 | |     onclick(MouseEvent)
+135 | |
 ...   |
-    | |     ontransitionstart(TransitionEvent)
-    | | }
+196 | |     ontransitionstart(TransitionEvent)
+197 | | }
     | |_- required by this bound in `yew::html::onclick::Wrapper::__macro_new`
     |
     = help: the trait `Fn<(MouseEvent,)>` is not implemented for `{integer}`
@@ -334,12 +334,12 @@ error[E0277]: expected a `Fn<(MouseEvent,)>` closure, found `yew::Callback<Strin
    ::: $WORKSPACE/packages/yew/src/html/listener/events.rs
     |
     | / impl_short! {
-    | |     onauxclick(MouseEvent)
-    | |     onclick(MouseEvent)
-    | |
+133 | |     onauxclick(MouseEvent)
+134 | |     onclick(MouseEvent)
+135 | |
 ...   |
-    | |     ontransitionstart(TransitionEvent)
-    | | }
+196 | |     ontransitionstart(TransitionEvent)
+197 | | }
     | |_- required by this bound in `yew::html::onclick::Wrapper::__macro_new`
     |
     = note: the trait bound `yew::Callback<String>: IntoEventCallback<MouseEvent>` is not satisfied
@@ -354,12 +354,12 @@ error[E0277]: the trait bound `Option<{integer}>: IntoEventCallback<FocusEvent>`
    ::: $WORKSPACE/packages/yew/src/html/listener/events.rs
     |
     | / impl_short! {
-    | |     onauxclick(MouseEvent)
-    | |     onclick(MouseEvent)
-    | |
+133 | |     onauxclick(MouseEvent)
+134 | |     onclick(MouseEvent)
+135 | |
 ...   |
-    | |     ontransitionstart(TransitionEvent)
-    | | }
+196 | |     ontransitionstart(TransitionEvent)
+197 | | }
     | |_- required by this bound in `yew::html::onfocus::Wrapper::__macro_new`
     |
     = help: the following implementations were found:
@@ -398,12 +398,12 @@ error[E0277]: expected a `Fn<(MouseEvent,)>` closure, found `yew::Callback<Strin
    ::: $WORKSPACE/packages/yew/src/html/listener/events.rs
     |
     | / impl_short! {
-    | |     onauxclick(MouseEvent)
-    | |     onclick(MouseEvent)
-    | |
+133 | |     onauxclick(MouseEvent)
+134 | |     onclick(MouseEvent)
+135 | |
 ...   |
-    | |     ontransitionstart(TransitionEvent)
-    | | }
+196 | |     ontransitionstart(TransitionEvent)
+197 | | }
     | |_- required by this bound in `yew::html::onclick::Wrapper::__macro_new`
     |
     = note: the trait bound `yew::Callback<String>: IntoEventCallback<MouseEvent>` is not satisfied

From 118a8dc506d8a771b4d9cc567e80f1f3d6df120f Mon Sep 17 00:00:00 2001
From: Kaede Hoshikawa <futursolo@icloud.com>
Date: Thu, 14 Oct 2021 19:21:43 +0900
Subject: [PATCH 5/8] Remove Redirect.

---
 packages/yew-router/src/components/mod.rs     |  2 --
 .../yew-router/src/components/redirect.rs     | 32 -------------------
 packages/yew-router/src/lib.rs                |  2 +-
 3 files changed, 1 insertion(+), 35 deletions(-)
 delete mode 100644 packages/yew-router/src/components/redirect.rs

diff --git a/packages/yew-router/src/components/mod.rs b/packages/yew-router/src/components/mod.rs
index bcec0215fb9..b6808da2757 100644
--- a/packages/yew-router/src/components/mod.rs
+++ b/packages/yew-router/src/components/mod.rs
@@ -1,6 +1,4 @@
 //! Components to interface with [Router][crate::Router].
 
 mod link;
-mod redirect;
 pub use link::*;
-pub use redirect::*;
diff --git a/packages/yew-router/src/components/redirect.rs b/packages/yew-router/src/components/redirect.rs
deleted file mode 100644
index a8b31e7ec21..00000000000
--- a/packages/yew-router/src/components/redirect.rs
+++ /dev/null
@@ -1,32 +0,0 @@
-use crate::{service, Routable};
-use std::marker::PhantomData;
-use yew::prelude::*;
-
-/// Props for [`Redirect`]
-#[derive(Properties, Clone, PartialEq)]
-pub struct RedirectProps<R: Routable + Clone + PartialEq> {
-    /// Route that will be pushed when the component is rendered.
-    pub to: R,
-}
-
-/// A component that will redirect to specified route when rendered.
-pub struct Redirect<R: Routable + Clone + PartialEq + 'static> {
-    _data: PhantomData<R>,
-}
-
-impl<R> Component for Redirect<R>
-where
-    R: Routable + Clone + PartialEq + 'static,
-{
-    type Message = ();
-    type Properties = RedirectProps<R>;
-
-    fn create(_ctx: &Context<Self>) -> Self {
-        Self { _data: PhantomData }
-    }
-
-    fn view(&self, ctx: &Context<Self>) -> Html {
-        service::push_route(ctx.props().to.clone());
-        Html::default()
-    }
-}
diff --git a/packages/yew-router/src/lib.rs b/packages/yew-router/src/lib.rs
index 97245e4673d..80d64dac708 100644
--- a/packages/yew-router/src/lib.rs
+++ b/packages/yew-router/src/lib.rs
@@ -74,7 +74,7 @@ pub mod prelude {
     //!
     //! This module re-exports the frequently used types from the crate.
 
-    pub use crate::components::{Link, Redirect};
+    pub use crate::components::Link;
     #[doc(no_inline)]
     pub use crate::Routable;
     pub use crate::Router;

From 02ce5dd705575e8fec3a4e45a8fbcb8d47bea60d Mon Sep 17 00:00:00 2001
From: Kaede Hoshikawa <futursolo@icloud.com>
Date: Fri, 15 Oct 2021 12:25:28 +0900
Subject: [PATCH 6/8] Readd 77b46bf.

---
 .../tests/html_macro/element-fail.stderr      | 150 +++++++++---------
 1 file changed, 75 insertions(+), 75 deletions(-)

diff --git a/packages/yew-macro/tests/html_macro/element-fail.stderr b/packages/yew-macro/tests/html_macro/element-fail.stderr
index 4ce990ed9e8..a69e3e4958e 100644
--- a/packages/yew-macro/tests/html_macro/element-fail.stderr
+++ b/packages/yew-macro/tests/html_macro/element-fail.stderr
@@ -1,209 +1,209 @@
 error: this opening tag has no corresponding closing tag
- --> $DIR/element-fail.rs:7:13
+ --> $DIR/tests/html_macro/element-fail.rs:7:13
   |
 7 |     html! { <div> };
   |             ^^^^^
 
 error: this opening tag has no corresponding closing tag
- --> $DIR/element-fail.rs:8:18
+ --> $DIR/tests/html_macro/element-fail.rs:8:18
   |
 8 |     html! { <div><div> };
   |                  ^^^^^
 
 error: this opening tag has no corresponding closing tag
- --> $DIR/element-fail.rs:9:13
+ --> $DIR/tests/html_macro/element-fail.rs:9:13
   |
 9 |     html! { <div><div></div> };
   |             ^^^^^
 
 error: this closing tag has no corresponding opening tag
-  --> $DIR/element-fail.rs:12:13
+  --> $DIR/tests/html_macro/element-fail.rs:12:13
    |
 12 |     html! { </div> };
    |             ^^^^^^
 
 error: this closing tag has no corresponding opening tag
-  --> $DIR/element-fail.rs:13:18
+  --> $DIR/tests/html_macro/element-fail.rs:13:18
    |
 13 |     html! { <div></span></div> };
    |                  ^^^^^^^
 
 error: only one root html element is allowed (hint: you can wrap multiple html elements in a fragment `<></>`)
-  --> $DIR/element-fail.rs:14:20
+  --> $DIR/tests/html_macro/element-fail.rs:14:20
    |
 14 |     html! { <img /></img> };
    |                    ^^^^^^
 
 error: this closing tag has no corresponding opening tag
-  --> $DIR/element-fail.rs:17:18
+  --> $DIR/tests/html_macro/element-fail.rs:17:18
    |
 17 |     html! { <div></span> };
    |                  ^^^^^^^
 
 error: this closing tag has no corresponding opening tag
-  --> $DIR/element-fail.rs:18:20
+  --> $DIR/tests/html_macro/element-fail.rs:18:20
    |
 18 |     html! { <tag-a></tag-b> };
    |                    ^^^^^^^^
 
 error: only one root html element is allowed (hint: you can wrap multiple html elements in a fragment `<></>`)
-  --> $DIR/element-fail.rs:21:24
+  --> $DIR/tests/html_macro/element-fail.rs:21:24
    |
 21 |     html! { <div></div><div></div> };
    |                        ^^^^^^^^^^^
 
 error: expected a valid html element
-  --> $DIR/element-fail.rs:23:18
+  --> $DIR/tests/html_macro/element-fail.rs:23:18
    |
 23 |     html! { <div>Invalid</div> };
    |                  ^^^^^^^
 
 error: `attr` can only be specified once but is given here again
-  --> $DIR/element-fail.rs:26:27
+  --> $DIR/tests/html_macro/element-fail.rs:26:27
    |
 26 |     html! { <input attr=1 attr=2 /> };
    |                           ^^^^
 
 error: `value` can only be specified once but is given here again
-  --> $DIR/element-fail.rs:27:32
+  --> $DIR/tests/html_macro/element-fail.rs:27:32
    |
 27 |     html! { <input value="123" value="456" /> };
    |                                ^^^^^
 
 error: `kind` can only be specified once but is given here again
-  --> $DIR/element-fail.rs:28:36
+  --> $DIR/tests/html_macro/element-fail.rs:28:36
    |
 28 |     html! { <input kind="checkbox" kind="submit" /> };
    |                                    ^^^^
 
 error: `checked` can only be specified once but is given here again
-  --> $DIR/element-fail.rs:29:33
+  --> $DIR/tests/html_macro/element-fail.rs:29:33
    |
 29 |     html! { <input checked=true checked=false /> };
    |                                 ^^^^^^^
 
 error: `disabled` can only be specified once but is given here again
-  --> $DIR/element-fail.rs:30:34
+  --> $DIR/tests/html_macro/element-fail.rs:30:34
    |
 30 |     html! { <input disabled=true disabled=false /> };
    |                                  ^^^^^^^^
 
 error: `selected` can only be specified once but is given here again
-  --> $DIR/element-fail.rs:31:35
+  --> $DIR/tests/html_macro/element-fail.rs:31:35
    |
 31 |     html! { <option selected=true selected=false /> };
    |                                   ^^^^^^^^
 
 error: `class` can only be specified once but is given here again
-  --> $DIR/element-fail.rs:32:32
+  --> $DIR/tests/html_macro/element-fail.rs:32:32
    |
 32 |     html! { <div class="first" class="second" /> };
    |                                ^^^^^
 
 error: `ref` can only be specified once
-  --> $DIR/element-fail.rs:33:20
+  --> $DIR/tests/html_macro/element-fail.rs:33:20
    |
 33 |     html! { <input ref={()} ref={()} /> };
    |                    ^^^
 
 error: `ref` can only be specified once
-  --> $DIR/element-fail.rs:63:20
+  --> $DIR/tests/html_macro/element-fail.rs:63:20
    |
 63 |     html! { <input ref={()} ref={()} /> };
    |                    ^^^
 
 error: the tag `<input>` is a void element and cannot have children (hint: rewrite this as `<input/>`)
-  --> $DIR/element-fail.rs:66:13
+  --> $DIR/tests/html_macro/element-fail.rs:66:13
    |
 66 |     html! { <input type="text"></input> };
    |             ^^^^^^^^^^^^^^^^^^^
 
 error: the tag `<iNpUt>` is a void element and cannot have children (hint: rewrite this as `<iNpUt/>`)
-  --> $DIR/element-fail.rs:68:13
+  --> $DIR/tests/html_macro/element-fail.rs:68:13
    |
 68 |     html! { <iNpUt type="text"></iNpUt> };
    |             ^^^^^^^^^^^^^^^^^^^
 
 error: this dynamic tag is missing an expression block defining its value
-  --> $DIR/element-fail.rs:71:14
+  --> $DIR/tests/html_macro/element-fail.rs:71:14
    |
 71 |     html! { <@></@> };
    |              ^
 
 error: this dynamic tag is missing an expression block defining its value
-  --> $DIR/element-fail.rs:72:14
+  --> $DIR/tests/html_macro/element-fail.rs:72:14
    |
 72 |     html! { <@/> };
    |              ^
 
 error: dynamic closing tags must not have a body (hint: replace it with just `</@>`)
-  --> $DIR/element-fail.rs:75:27
+  --> $DIR/tests/html_macro/element-fail.rs:75:27
    |
 75 |     html! { <@{"test"}></@{"test"}> };
    |                           ^^^^^^^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/element-fail.rs:83:24
+  --> $DIR/tests/html_macro/element-fail.rs:83:24
    |
 83 |     html! { <div class=("deprecated", "warning") /> };
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/element-fail.rs:84:24
+  --> $DIR/tests/html_macro/element-fail.rs:84:24
    |
 84 |     html! { <input ref=() /> };
    |                        ^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/element-fail.rs:85:24
+  --> $DIR/tests/html_macro/element-fail.rs:85:24
    |
 85 |     html! { <input ref=() ref=() /> };
    |                        ^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/element-fail.rs:86:28
+  --> $DIR/tests/html_macro/element-fail.rs:86:28
    |
 86 |     html! { <input onfocus=Some(5) /> };
    |                            ^^^^^^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/element-fail.rs:87:27
+  --> $DIR/tests/html_macro/element-fail.rs:87:27
    |
 87 |     html! { <input string=NotToString /> };
    |                           ^^^^^^^^^^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/element-fail.rs:88:22
+  --> $DIR/tests/html_macro/element-fail.rs:88:22
    |
 88 |     html! { <a media=Some(NotToString) /> };
    |                      ^^^^^^^^^^^^^^^^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/element-fail.rs:89:21
+  --> $DIR/tests/html_macro/element-fail.rs:89:21
    |
 89 |     html! { <a href=Some(5) /> };
    |                     ^^^^^^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/element-fail.rs:90:25
+  --> $DIR/tests/html_macro/element-fail.rs:90:25
    |
 90 |     html! { <input type=() /> };
    |                         ^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/element-fail.rs:91:26
+  --> $DIR/tests/html_macro/element-fail.rs:91:26
    |
 91 |     html! { <input value=() /> };
    |                          ^^
 
 error: the property value must be either a literal or enclosed in braces. Consider adding braces around your expression.
-  --> $DIR/element-fail.rs:92:27
+  --> $DIR/tests/html_macro/element-fail.rs:92:27
    |
 92 |     html! { <input string=NotToString /> };
    |                           ^^^^^^^^^^^
 
 warning: use of deprecated function `compile_fail::deprecated_use_of_class`: the use of `(...)` with the attribute `class` is deprecated and will be removed in version 0.19. Use the `classes!` macro instead.
-  --> $DIR/element-fail.rs:80:25
+  --> $DIR/tests/html_macro/element-fail.rs:80:25
    |
 80 |     html! { <div class={("deprecated", "warning")} /> };
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -211,13 +211,13 @@ warning: use of deprecated function `compile_fail::deprecated_use_of_class`: the
    = note: `#[warn(deprecated)]` on by default
 
 error[E0308]: mismatched types
-  --> $DIR/element-fail.rs:36:28
+  --> $DIR/tests/html_macro/element-fail.rs:36:28
    |
 36 |     html! { <input checked=1 /> };
    |                            ^ expected `bool`, found integer
 
 error[E0308]: mismatched types
-  --> $DIR/element-fail.rs:37:29
+  --> $DIR/tests/html_macro/element-fail.rs:37:29
    |
 37 |     html! { <input checked={Some(false)} /> };
    |                             ^^^^^^^^^^^ expected `bool`, found enum `Option`
@@ -226,13 +226,13 @@ error[E0308]: mismatched types
               found enum `Option<bool>`
 
 error[E0308]: mismatched types
-  --> $DIR/element-fail.rs:38:29
+  --> $DIR/tests/html_macro/element-fail.rs:38:29
    |
 38 |     html! { <input disabled=1 /> };
    |                             ^ expected `bool`, found integer
 
 error[E0308]: mismatched types
-  --> $DIR/element-fail.rs:39:30
+  --> $DIR/tests/html_macro/element-fail.rs:39:30
    |
 39 |     html! { <input disabled={Some(true)} /> };
    |                              ^^^^^^^^^^ expected `bool`, found enum `Option`
@@ -241,13 +241,13 @@ error[E0308]: mismatched types
               found enum `Option<bool>`
 
 error[E0308]: mismatched types
-  --> $DIR/element-fail.rs:40:30
+  --> $DIR/tests/html_macro/element-fail.rs:40:30
    |
 40 |     html! { <option selected=1 /> };
    |                              ^ expected `bool`, found integer
 
 error[E0277]: the trait bound `(): IntoPropValue<Option<Cow<'static, str>>>` is not satisfied
-  --> $DIR/element-fail.rs:43:26
+  --> $DIR/tests/html_macro/element-fail.rs:43:26
    |
 43 |     html! { <input type={()} /> };
    |                          ^^ the trait `IntoPropValue<Option<Cow<'static, str>>>` is not implemented for `()`
@@ -255,7 +255,7 @@ error[E0277]: the trait bound `(): IntoPropValue<Option<Cow<'static, str>>>` is
    = note: required by `into_prop_value`
 
 error[E0277]: the trait bound `(): IntoPropValue<Option<Cow<'static, str>>>` is not satisfied
-  --> $DIR/element-fail.rs:44:27
+  --> $DIR/tests/html_macro/element-fail.rs:44:27
    |
 44 |     html! { <input value={()} /> };
    |                           ^^ the trait `IntoPropValue<Option<Cow<'static, str>>>` is not implemented for `()`
@@ -263,7 +263,7 @@ error[E0277]: the trait bound `(): IntoPropValue<Option<Cow<'static, str>>>` is
    = note: required by `into_prop_value`
 
 error[E0277]: the trait bound `(): IntoPropValue<Option<Cow<'static, str>>>` is not satisfied
-  --> $DIR/element-fail.rs:45:22
+  --> $DIR/tests/html_macro/element-fail.rs:45:22
    |
 45 |     html! { <a href={()} /> };
    |                      ^^ the trait `IntoPropValue<Option<Cow<'static, str>>>` is not implemented for `()`
@@ -271,7 +271,7 @@ error[E0277]: the trait bound `(): IntoPropValue<Option<Cow<'static, str>>>` is
    = note: required by `into_prop_value`
 
 error[E0277]: the trait bound `NotToString: IntoPropValue<Option<Cow<'static, str>>>` is not satisfied
-  --> $DIR/element-fail.rs:46:28
+  --> $DIR/tests/html_macro/element-fail.rs:46:28
    |
 46 |     html! { <input string={NotToString} /> };
    |                            ^^^^^^^^^^^ the trait `IntoPropValue<Option<Cow<'static, str>>>` is not implemented for `NotToString`
@@ -279,7 +279,7 @@ error[E0277]: the trait bound `NotToString: IntoPropValue<Option<Cow<'static, st
    = note: required by `into_prop_value`
 
 error[E0277]: the trait bound `Option<NotToString>: IntoPropValue<Option<Cow<'static, str>>>` is not satisfied
-  --> $DIR/element-fail.rs:47:23
+  --> $DIR/tests/html_macro/element-fail.rs:47:23
    |
 47 |     html! { <a media={Some(NotToString)} /> };
    |                       ^^^^^^^^^^^^^^^^^ the trait `IntoPropValue<Option<Cow<'static, str>>>` is not implemented for `Option<NotToString>`
@@ -291,7 +291,7 @@ error[E0277]: the trait bound `Option<NotToString>: IntoPropValue<Option<Cow<'st
    = note: required by `into_prop_value`
 
 error[E0277]: the trait bound `Option<{integer}>: IntoPropValue<Option<Cow<'static, str>>>` is not satisfied
-  --> $DIR/element-fail.rs:48:22
+  --> $DIR/tests/html_macro/element-fail.rs:48:22
    |
 48 |     html! { <a href={Some(5)} /> };
    |                      ^^^^^^^ the trait `IntoPropValue<Option<Cow<'static, str>>>` is not implemented for `Option<{integer}>`
@@ -303,7 +303,7 @@ error[E0277]: the trait bound `Option<{integer}>: IntoPropValue<Option<Cow<'stat
    = note: required by `into_prop_value`
 
 error[E0277]: expected a `Fn<(MouseEvent,)>` closure, found `{integer}`
-   --> $DIR/element-fail.rs:51:28
+   --> $DIR/tests/html_macro/element-fail.rs:51:28
     |
 51  |       html! { <input onclick=1 /> };
     |                              ^ expected an `Fn<(MouseEvent,)>` closure, found `{integer}`
@@ -311,19 +311,19 @@ error[E0277]: expected a `Fn<(MouseEvent,)>` closure, found `{integer}`
    ::: $WORKSPACE/packages/yew/src/html/listener/events.rs
     |
     | / impl_short! {
-133 | |     onauxclick(MouseEvent)
-134 | |     onclick(MouseEvent)
-135 | |
+    | |     onauxclick(MouseEvent)
+    | |     onclick(MouseEvent)
+    | |
 ...   |
-196 | |     ontransitionstart(TransitionEvent)
-197 | | }
+    | |     ontransitionstart(TransitionEvent)
+    | | }
     | |_- required by this bound in `yew::html::onclick::Wrapper::__macro_new`
     |
     = help: the trait `Fn<(MouseEvent,)>` is not implemented for `{integer}`
     = note: required because of the requirements on the impl of `IntoEventCallback<MouseEvent>` for `{integer}`
 
 error[E0277]: expected a `Fn<(MouseEvent,)>` closure, found `yew::Callback<String>`
-   --> $DIR/element-fail.rs:52:29
+   --> $DIR/tests/html_macro/element-fail.rs:52:29
     |
 52  |       html! { <input onclick={Callback::from(|a: String| ())} /> };
     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -334,19 +334,19 @@ error[E0277]: expected a `Fn<(MouseEvent,)>` closure, found `yew::Callback<Strin
    ::: $WORKSPACE/packages/yew/src/html/listener/events.rs
     |
     | / impl_short! {
-133 | |     onauxclick(MouseEvent)
-134 | |     onclick(MouseEvent)
-135 | |
+    | |     onauxclick(MouseEvent)
+    | |     onclick(MouseEvent)
+    | |
 ...   |
-196 | |     ontransitionstart(TransitionEvent)
-197 | | }
+    | |     ontransitionstart(TransitionEvent)
+    | | }
     | |_- required by this bound in `yew::html::onclick::Wrapper::__macro_new`
     |
     = note: the trait bound `yew::Callback<String>: IntoEventCallback<MouseEvent>` is not satisfied
     = note: required because of the requirements on the impl of `IntoEventCallback<MouseEvent>` for `yew::Callback<String>`
 
 error[E0277]: the trait bound `Option<{integer}>: IntoEventCallback<FocusEvent>` is not satisfied
-   --> $DIR/element-fail.rs:53:29
+   --> $DIR/tests/html_macro/element-fail.rs:53:29
     |
 53  |       html! { <input onfocus={Some(5)} /> };
     |                               ^^^^^^^ the trait `IntoEventCallback<FocusEvent>` is not implemented for `Option<{integer}>`
@@ -354,12 +354,12 @@ error[E0277]: the trait bound `Option<{integer}>: IntoEventCallback<FocusEvent>`
    ::: $WORKSPACE/packages/yew/src/html/listener/events.rs
     |
     | / impl_short! {
-133 | |     onauxclick(MouseEvent)
-134 | |     onclick(MouseEvent)
-135 | |
+    | |     onauxclick(MouseEvent)
+    | |     onclick(MouseEvent)
+    | |
 ...   |
-196 | |     ontransitionstart(TransitionEvent)
-197 | | }
+    | |     ontransitionstart(TransitionEvent)
+    | | }
     | |_- required by this bound in `yew::html::onfocus::Wrapper::__macro_new`
     |
     = help: the following implementations were found:
@@ -367,7 +367,7 @@ error[E0277]: the trait bound `Option<{integer}>: IntoEventCallback<FocusEvent>`
               <Option<yew::Callback<EVENT>> as IntoEventCallback<EVENT>>
 
 error[E0277]: the trait bound `(): IntoPropValue<yew::NodeRef>` is not satisfied
-  --> $DIR/element-fail.rs:56:25
+  --> $DIR/tests/html_macro/element-fail.rs:56:25
    |
 56 |     html! { <input ref={()} /> };
    |                         ^^ the trait `IntoPropValue<yew::NodeRef>` is not implemented for `()`
@@ -375,7 +375,7 @@ error[E0277]: the trait bound `(): IntoPropValue<yew::NodeRef>` is not satisfied
    = note: required by `into_prop_value`
 
 error[E0277]: the trait bound `Option<yew::NodeRef>: IntoPropValue<yew::NodeRef>` is not satisfied
-  --> $DIR/element-fail.rs:57:25
+  --> $DIR/tests/html_macro/element-fail.rs:57:25
    |
 57 |     html! { <input ref={Some(NodeRef::default())} /> };
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^ the trait `IntoPropValue<yew::NodeRef>` is not implemented for `Option<yew::NodeRef>`
@@ -387,7 +387,7 @@ error[E0277]: the trait bound `Option<yew::NodeRef>: IntoPropValue<yew::NodeRef>
    = note: required by `into_prop_value`
 
 error[E0277]: expected a `Fn<(MouseEvent,)>` closure, found `yew::Callback<String>`
-   --> $DIR/element-fail.rs:58:29
+   --> $DIR/tests/html_macro/element-fail.rs:58:29
     |
 58  |       html! { <input onclick={Callback::from(|a: String| ())} /> };
     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -398,19 +398,19 @@ error[E0277]: expected a `Fn<(MouseEvent,)>` closure, found `yew::Callback<Strin
    ::: $WORKSPACE/packages/yew/src/html/listener/events.rs
     |
     | / impl_short! {
-133 | |     onauxclick(MouseEvent)
-134 | |     onclick(MouseEvent)
-135 | |
+    | |     onauxclick(MouseEvent)
+    | |     onclick(MouseEvent)
+    | |
 ...   |
-196 | |     ontransitionstart(TransitionEvent)
-197 | | }
+    | |     ontransitionstart(TransitionEvent)
+    | | }
     | |_- required by this bound in `yew::html::onclick::Wrapper::__macro_new`
     |
     = note: the trait bound `yew::Callback<String>: IntoEventCallback<MouseEvent>` is not satisfied
     = note: required because of the requirements on the impl of `IntoEventCallback<MouseEvent>` for `yew::Callback<String>`
 
 error[E0277]: the trait bound `NotToString: IntoPropValue<Option<Cow<'static, str>>>` is not satisfied
-  --> $DIR/element-fail.rs:60:28
+  --> $DIR/tests/html_macro/element-fail.rs:60:28
    |
 60 |     html! { <input string={NotToString} /> };
    |                            ^^^^^^^^^^^ the trait `IntoPropValue<Option<Cow<'static, str>>>` is not implemented for `NotToString`
@@ -418,7 +418,7 @@ error[E0277]: the trait bound `NotToString: IntoPropValue<Option<Cow<'static, st
    = note: required by `into_prop_value`
 
 error[E0277]: the trait bound `(): IntoPropValue<yew::NodeRef>` is not satisfied
-  --> $DIR/element-fail.rs:62:25
+  --> $DIR/tests/html_macro/element-fail.rs:62:25
    |
 62 |     html! { <input ref={()} /> };
    |                         ^^ the trait `IntoPropValue<yew::NodeRef>` is not implemented for `()`
@@ -426,7 +426,7 @@ error[E0277]: the trait bound `(): IntoPropValue<yew::NodeRef>` is not satisfied
    = note: required by `into_prop_value`
 
 error[E0277]: the trait bound `Cow<'static, str>: From<{integer}>` is not satisfied
-  --> $DIR/element-fail.rs:77:15
+  --> $DIR/tests/html_macro/element-fail.rs:77:15
    |
 77 |     html! { <@{55}></@> };
    |               ^^^^ the trait `From<{integer}>` is not implemented for `Cow<'static, str>`

From 412459512ebff8557b9bbb6f8782b77df46b8cb5 Mon Sep 17 00:00:00 2001
From: Kaede Hoshikawa <futursolo@icloud.com>
Date: Sun, 31 Oct 2021 14:15:48 +0900
Subject: [PATCH 7/8] Add use_bridge hook.

---
 packages/yew-agent/src/hooks.rs | 56 +++++++++++++++++++++++++++++++++
 packages/yew-agent/src/lib.rs   |  2 ++
 2 files changed, 58 insertions(+)
 create mode 100644 packages/yew-agent/src/hooks.rs

diff --git a/packages/yew-agent/src/hooks.rs b/packages/yew-agent/src/hooks.rs
new file mode 100644
index 00000000000..5a93ee56c8a
--- /dev/null
+++ b/packages/yew-agent/src/hooks.rs
@@ -0,0 +1,56 @@
+use std::cell::RefCell;
+use std::rc::Rc;
+
+use crate::*;
+use yew::prelude::*;
+
+/// State handle for [`use_bridge`] hook
+pub struct UseBridgeHandle<T>
+where
+    T: Bridged,
+{
+    inner: Rc<RefCell<Box<dyn Bridge<T>>>>,
+}
+
+impl<T> UseBridgeHandle<T>
+where
+    T: Bridged,
+{
+    /// Send a message to an agent.
+    pub fn send(&self, msg: T::Input) {
+        let mut bridge = self.inner.borrow_mut();
+        bridge.send(msg);
+    }
+}
+
+/// A hook to bridge to an Agent.
+///
+/// This hooks will only bridge the agent once over the entire component lifecycle.
+///
+/// Takes a callback as the only argument. The callback will be updated on every render to make
+/// sure captured values (if any) are up to date.
+pub fn use_bridge<T, F>(on_output: F) -> UseBridgeHandle<T>
+where
+    T: Bridged,
+    F: Fn(T::Output) + 'static,
+{
+    let on_output = Rc::new(on_output);
+
+    let on_output_clone = on_output.clone();
+    let on_output_ref = use_ref(move || on_output_clone);
+
+    // Refresh the callback on every render.
+    {
+        let mut on_output_ref = on_output_ref.borrow_mut();
+        *on_output_ref = on_output;
+    }
+
+    let bridge = use_ref(move || {
+        T::bridge(Callback::from(move |output| {
+            let on_output = on_output_ref.borrow().clone();
+            on_output(output);
+        }))
+    });
+
+    UseBridgeHandle { inner: bridge }
+}
diff --git a/packages/yew-agent/src/lib.rs b/packages/yew-agent/src/lib.rs
index 90fba65e566..17232e63e23 100644
--- a/packages/yew-agent/src/lib.rs
+++ b/packages/yew-agent/src/lib.rs
@@ -1,11 +1,13 @@
 //! This module contains types to support multi-threading and state management.
 
+mod hooks;
 mod link;
 mod local;
 mod pool;
 pub mod utils;
 mod worker;
 
+pub use hooks::{use_bridge, UseBridgeHandle};
 pub use link::AgentLink;
 pub(crate) use link::*;
 pub use local::{Context, Job};

From bf756663befa88431f69ffdc5e9ff876b90942ae Mon Sep 17 00:00:00 2001
From: Kaede Hoshikawa <futursolo@icloud.com>
Date: Fri, 12 Nov 2021 10:57:36 +0900
Subject: [PATCH 8/8] Add documentation.

---
 website/docs/concepts/agents.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/website/docs/concepts/agents.md b/website/docs/concepts/agents.md
index 637096d84f7..db1e877d837 100644
--- a/website/docs/concepts/agents.md
+++ b/website/docs/concepts/agents.md
@@ -36,6 +36,8 @@ In order for agents to run concurrently, Yew uses [web-workers](https://develope
 
 A bridge allows bi-directional communication between an agent and a component. Bridges also allow agents to communicate with one another.
 
+A `use_bridge` hook is also provided to create bridges in a function component.
+
 ### Dispatchers
 
 A dispatcher allows uni-directional communication between a component and an agent. A dispatcher allows a component to send messages to an agent.