From fcbd5c88f472b3d3405d199e8030497376d57e66 Mon Sep 17 00:00:00 2001 From: yi0713 Date: Wed, 7 Nov 2018 18:58:18 +0900 Subject: [PATCH] Revert "Temporarily hold timeline if mouse moved recently (fixes #8630) (#9200)" This reverts commit 6a1216d2cd1c26c22baf86ae618a62aa66817239. --- .../mastodon/components/scrollable_list.js | 50 +------------------ 1 file changed, 2 insertions(+), 48 deletions(-) diff --git a/app/javascript/mastodon/components/scrollable_list.js b/app/javascript/mastodon/components/scrollable_list.js index e51c83c2b81fc2..5c888650c37133 100644 --- a/app/javascript/mastodon/components/scrollable_list.js +++ b/app/javascript/mastodon/components/scrollable_list.js @@ -9,8 +9,6 @@ import { List as ImmutableList } from 'immutable'; import classNames from 'classnames'; import { attachFullscreenListener, detachFullscreenListener, isFullscreen } from '../features/ui/util/fullscreen'; -const MOUSE_IDLE_DELAY = 300; - export default class ScrollableList extends PureComponent { static contextTypes = { @@ -39,8 +37,6 @@ export default class ScrollableList extends PureComponent { state = { fullscreen: null, - mouseMovedRecently: false, - scrollToTopOnMouseIdle: false, }; intersectionObserverWrapper = new IntersectionObserverWrapper(); @@ -64,47 +60,6 @@ export default class ScrollableList extends PureComponent { trailing: true, }); - mouseIdleTimer = null; - - clearMouseIdleTimer = () => { - if (this.mouseIdleTimer === null) { - return; - } - clearTimeout(this.mouseIdleTimer); - this.mouseIdleTimer = null; - }; - - handleMouseMove = throttle(() => { - // As long as the mouse keeps moving, clear and restart the idle timer. - this.clearMouseIdleTimer(); - this.mouseIdleTimer = - setTimeout(this.handleMouseIdle, MOUSE_IDLE_DELAY); - - this.setState(({ - mouseMovedRecently, - scrollToTopOnMouseIdle, - }) => ({ - mouseMovedRecently: true, - // Only set scrollToTopOnMouseIdle if we just started moving and were - // scrolled to the top. Otherwise, just retain the previous state. - scrollToTopOnMouseIdle: - mouseMovedRecently - ? scrollToTopOnMouseIdle - : (this.node.scrollTop === 0), - })); - }, MOUSE_IDLE_DELAY / 2); - - handleMouseIdle = () => { - if (this.state.scrollToTopOnMouseIdle) { - this.node.scrollTop = 0; - this.props.onScrollToTop(); - } - this.setState({ - mouseMovedRecently: false, - scrollToTopOnMouseIdle: false, - }); - } - componentDidMount () { this.attachScrollListener(); this.attachIntersectionObserver(); @@ -118,7 +73,7 @@ export default class ScrollableList extends PureComponent { const someItemInserted = React.Children.count(prevProps.children) > 0 && React.Children.count(prevProps.children) < React.Children.count(this.props.children) && this.getFirstChildKey(prevProps) !== this.getFirstChildKey(this.props); - if ((someItemInserted && this.node.scrollTop > 0) || this.state.mouseMovedRecently) { + if (someItemInserted && this.node.scrollTop > 0) { return this.node.scrollHeight - this.node.scrollTop; } else { return null; @@ -138,7 +93,6 @@ export default class ScrollableList extends PureComponent { } componentWillUnmount () { - this.clearMouseIdleTimer(); this.detachScrollListener(); this.detachIntersectionObserver(); detachFullscreenListener(this.onFullScreenChange); @@ -197,7 +151,7 @@ export default class ScrollableList extends PureComponent { if (isLoading || childrenCount > 0 || !emptyMessage) { scrollableArea = ( -
+
{prepend}