-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove multi-context restrictions for publishing image sequences on farm #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
type: enhancement
Improvement of existing functionality or minor addition
size/XS
labels
Feb 29, 2024
BigRoy
reviewed
Feb 29, 2024
BigRoy
reviewed
Feb 29, 2024
BigRoy
reviewed
Feb 29, 2024
BigRoy
reviewed
Feb 29, 2024
BigRoy
reviewed
Feb 29, 2024
tokejepsen
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully in Nuke 15.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Removing assert that context data must be same as instance data will allow publishing image data to different context in one go.
That sanity check was there because we didn't support publishing to different context before (like multishot workflow), but this should be possible now.
⚰️ This is also removing support for multiple jsons files as it was just complicating the code and it wasn't used anywhere.
Additional info
More work on different DCCs needs to be done to seamlessly support multishot workflow - like Maya restrict only one rendering instance, Nuke enforce unique instance name (so you can't publish renderMain to multiple shots), etc.
Testing notes:
Note
This is
ayon-core
version of ynput/OpenPype#6088[cuID:AY-1003]