Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max: Allows user to select material duplicates option during loading max scene object #164

Merged
merged 9 commits into from
Mar 13, 2024

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Mar 8, 2024

Changelog Description

This PR is to add the options/dialogs to allow user to select material duplicates options when loading max scene via Loader.
(More Info to be updated)

Additional info

The material duplicate option would be at the default setting promptMtlDups when 3dsmax is at headless mode

Testing notes:

Load...

  1. Launch 3dsMax
  2. Go to AYON -> Load...
  3. Right Click load Max Scene and you will find memo icon
    image
  4. Click that memo icon, you can select your preferred material duplicate options.
    image
  5. Click Ok and it would load the max scene objects with your choice on material duplicate option.
    Updating/Switching Version...
  6. Go to AYON -> Manage...
  7. Set Version with the max scene product type
  8. After finishing to choose your version, it will pop up a dialog to ask to choose material duplicate types.
  9. Click Ok button
  10. The scene will update and load the objects with the chosen material duplicate type.
  11. If clicking cancel button, the scene will still update and load the objects with the default material duplicate type.

@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition host: 3dsmax size/XS labels Mar 8, 2024
@moonyuet moonyuet marked this pull request as ready for review March 9, 2024 14:34
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard for me to really understand whether this is the best design approach. You might have 10 max scenes loaded. I'd personally not want to click through 10 popups on update.

So can't really decide on what the best approach is for this use case but it does feel like an anti-pattern from the outside.

@moonyuet
Copy link
Member Author

It's hard for me to really understand whether this is the best design approach. You might have 10 max scenes loaded. I'd personally not want to click through 10 popups on update.

So can't really decide on what the best approach is for this use case but it does feel like an anti-pattern from the outside.

I am thinking about adding as loader setting into 3dsmax addon, when talking about the best approach.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems working fine in multiple occasions and circumstances...did test different scenarios with material and all options seems working as expected.

LGTM

image

@BigRoy
Copy link
Collaborator

BigRoy commented Mar 11, 2024

All seems working fine in multiple occasions and circumstances...did test different scenarios with material and all options seems working as expected.

LGTM
image

Can we please improve the labels on those drop down menu entries? :) What is promptMtlDups? Is there no way to improve readability on those labels?

Also @LiborBatek have you also tested the prompt/dialog on Update instead of Load?

@LiborBatek
Copy link
Member

LiborBatek commented Mar 12, 2024

All seems working fine in multiple occasions and circumstances...did test different scenarios with material and all options seems working as expected.
LGTM
image

Can we please improve the labels on those drop down menu entries? :) What is promptMtlDups? Is there no way to improve readability on those labels?

Also @LiborBatek have you also tested the prompt/dialog on Update instead of Load?

@BigRoy Yes I did, I loaded asset multiple times and manage it - in different and also same version...juggling with the options a lot speaking of those material settings. Trying different circumstances and how this PR behaves under conditions like duplicate shaders etc.

All seems working nicely and without any glitches (predictably).

@moonyuet
Copy link
Member Author

moonyuet commented Mar 12, 2024

All seems working fine in multiple occasions and circumstances...did test different scenarios with material and all options seems working as expected.
LGTM
image

Can we please improve the labels on those drop down menu entries? :) What is promptMtlDups? Is there no way to improve readability on those labels?

Also @LiborBatek have you also tested the prompt/dialog on Update instead of Load?

I edited the code to be more descriptives and artist friendly in terms of the choosing options.
image
image

@LiborBatek can you check again? Thank you!

@BigRoy
Copy link
Collaborator

BigRoy commented Mar 12, 2024

All seems working fine in multiple occasions and circumstances...did test different scenarios with material and all options seems working as expected.
LGTM
image

Can we please improve the labels on those drop down menu entries? :) What is promptMtlDups? Is there no way to improve readability on those labels?
Also @LiborBatek have you also tested the prompt/dialog on Update instead of Load?

I edited the code to be more descriptives and artist friendly in terms of the choosing options. image image

Much better - so what is Prompt Material? Is that like a Pick & Choose dialog?

@moonyuet
Copy link
Member Author

All seems working fine in multiple occasions and circumstances...did test different scenarios with material and all options seems working as expected.
LGTM
image

Can we please improve the labels on those drop down menu entries? :) What is promptMtlDups? Is there no way to improve readability on those labels?
Also @LiborBatek have you also tested the prompt/dialog on Update instead of Load?

I edited the code to be more descriptives and artist friendly in terms of the choosing options. image image

Much better - so what is Prompt Material? Is that like a Pick & Choose dialog?

According to the documentation, it means prompting the user when duplicated materials are found. But I think it's too long as the option's name.

@BigRoy
Copy link
Collaborator

BigRoy commented Mar 12, 2024

I see.

How about "Prompt on duplicate materials" - and I'm not sure what the "prompt" offers for the user. What happens with the prompt itself - is that like a 'decide what to include or skip' dialog?

@moonyuet moonyuet requested a review from BigRoy March 12, 2024 15:13
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't speak to the 3DsMax side of things nor from an angle of artists/usability (don't use max myself) but code seems good.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works fine and under all circumstances...

Also now being the options when using load much clearer for the user

image

@moonyuet moonyuet merged commit fc357fc into develop Mar 13, 2024
4 checks passed
@moonyuet moonyuet deleted the enhancement/AY-2130_Maxsceneloader branch March 13, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: 3dsmax size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants