-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Max: Allows user to select material duplicates option during loading max scene object #164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard for me to really understand whether this is the best design approach. You might have 10 max scenes loaded. I'd personally not want to click through 10 popups on update.
So can't really decide on what the best approach is for this use case but it does feel like an anti-pattern from the outside.
I am thinking about adding as loader setting into 3dsmax addon, when talking about the best approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please improve the labels on those drop down menu entries? :) What is Also @LiborBatek have you also tested the prompt/dialog on Update instead of Load? |
@BigRoy Yes I did, I loaded asset multiple times and manage it - in different and also same version...juggling with the options a lot speaking of those material settings. Trying different circumstances and how this PR behaves under conditions like duplicate shaders etc. All seems working nicely and without any glitches (predictably). |
I edited the code to be more descriptives and artist friendly in terms of the choosing options. @LiborBatek can you check again? Thank you! |
Much better - so what is Prompt Material? Is that like a Pick & Choose dialog? |
According to the documentation, it means |
I see. How about "Prompt on duplicate materials" - and I'm not sure what the "prompt" offers for the user. What happens with the prompt itself - is that like a 'decide what to include or skip' dialog? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't speak to the 3DsMax side of things nor from an angle of artists/usability (don't use max myself) but code seems good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog Description
This PR is to add the options/dialogs to allow user to select material duplicates options when loading max scene via Loader.
(More Info to be updated)
Additional info
The material duplicate option would be at the default setting
promptMtlDups
when 3dsmax is at headless modeTesting notes:
Load...
Updating/Switching Version...