-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nuke: Publish and load slate frame explicitly - AY-4055 #218
Nuke: Publish and load slate frame explicitly - AY-4055 #218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though I understand what it is trying to solve I feel things here are making this way more complicated than it really should be.
The assumption that a slate
is only ever 1 frame seems wrong - I have also historically seen 'animated slates' that last up to a second or two, like almost a bumper with color checks, etc. I feel like the slateFrame
true/false just doesn't account to that?
Yeah, I was thinking whether to account for that, but I've personally never encountered slate longer than 1 frame. @jakubjezek001 got any experience with this? |
Never had but we could be more safe if we do Thanks @BigRoy for mentioning this! |
Accounting for multiple slate frames now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect! thanks @tokejepsen
Changelog Description
Explicitly publish representations with
slateFrame
data member, so loading can query whether there is slate frame.Testing notes: