Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke: Publish and load slate frame explicitly - AY-4055 #218

Merged

Conversation

tokejepsen
Copy link
Member

Changelog Description

Explicitly publish representations with slateFrame data member, so loading can query whether there is slate frame.

Testing notes:

  1. Publish a slate render/review from Nuke.
  2. Load the render/review into Nuke.
  3. Validate slate is at the Nuke workfiles first frame minus 1.

@tokejepsen tokejepsen added the sponsored This is directly sponsored by a client or community member label Mar 21, 2024
@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition host: Nuke size/XS labels Mar 21, 2024
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I understand what it is trying to solve I feel things here are making this way more complicated than it really should be.

The assumption that a slate is only ever 1 frame seems wrong - I have also historically seen 'animated slates' that last up to a second or two, like almost a bumper with color checks, etc. I feel like the slateFrame true/false just doesn't account to that?

@tokejepsen
Copy link
Member Author

The assumption that a slate is only ever 1 frame seems wrong - I have also historically seen 'animated slates' that last up to a second or two, like almost a bumper with color checks, etc. I feel like the slateFrame true/false just doesn't account to that?

Yeah, I was thinking whether to account for that, but I've personally never encountered slate longer than 1 frame.

@jakubjezek001 got any experience with this?

@jakubjezek001
Copy link
Member

yeah, I was thinking whether to account for that, but I've personally never encountered slate longer than 1 frame.

Never had but we could be more safe if we do slateFrames as Int instead. This way in future we would be covered. But the refractory of the code for publishing plugins should happen in future on demand (those are only counting with single slate frame at the moment).

Thanks @BigRoy for mentioning this!

@tokejepsen
Copy link
Member Author

Accounting for multiple slate frames now.

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect! thanks @tokejepsen

@jakubjezek001 jakubjezek001 merged commit ad06217 into develop Apr 9, 2024
1 check failed
@jakubjezek001 jakubjezek001 deleted the enhancement/AY-4055_Explicit-slate-frame-metadata branch April 9, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Nuke size/XS sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants