Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya Settings: Extract Camera bake attributes title fix + add description #220

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Mar 24, 2024

Changelog Description

Settings for Maya Extract Camera "bake attributes" should now be labeled correctly and have a description.

Additional info

I did not bump the server addon version because it's cosmetics only for the settings. So it's fine it only starts showing in future releases.

Testing notes:

  1. Settings for Maya Extract Camera "bake attributes" should now be labeled correctly and have a description.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Mar 24, 2024

The settings field is currently a string that should be a json list, e.g. ["hello", "world"] would be a valid string the user needs to enter.
Would it make sense to actually transition that to a list of strings as input fields?
Similar to #221

Maybe @iLLiCiTiT can elaborate on how we might be able to do so with backwards compatibility (like using settings conversions?)


Also, we might want to remove the settings docstring which apparently is for this bake attributes and use that as the field's description instead.

image

Thoughts on moving that @Innders ? (It'd make it the tooltip instead of being in the top bar)

@BigRoy BigRoy requested a review from iLLiCiTiT March 24, 2024 10:26
@Innders
Copy link
Member

Innders commented Mar 24, 2024

I'm wondering if a "?" button that can either be clicked or hovered to reveal a tooltip would be better.

Otherwise it's not obvious there's extra info to see.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Mar 24, 2024

I'm wondering if a "?" button that can either be clicked or hovered to reveal a tooltip would be better.

Having a question mark icon for now while there aren't too many attributes with tooltips I think could be nice. However, I think we should just try and work towards almost everything getting tooltip descriptions (and then at some point it's everywhere and the question mark might become redundant.)

@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Mar 25, 2024
@iLLiCiTiT
Copy link
Member

The settings field is currently a string that should be a json list, e.g. ["hello", "world"] would be a valid string the user needs to enter.

My first question would be: "Why it was json at first place?". Conversion on server is possible, but client code conversion might be complicated, with combination of new maya settings and old ayon-core (or openpype). Could that wait until maya client code is bound to the server addon?

@BigRoy
Copy link
Collaborator Author

BigRoy commented Mar 26, 2024

My first question would be: "Why it was json at first place?". Conversion on server is possible, but client code conversion might be complicated, with combination of new maya settings and old ayon-core (or openpype). Could that wait until maya client code is bound to the server addon?

Sure can - this PR doesn't touch the fact that it's JSON - it just fixes the label "Base" to "Bake" and adds a description.
We'd just need to make an issue to track the fact that we want to convert the JSON to a list down the line.

Shall we also remove the docstring?

Also, we might want to remove the settings docstring which apparently is for this bake attributes and use that as the field's description instead.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Mar 26, 2024

Shall we also remove the docstring?

I've gone ahead and done this with fe8613b

@iLLiCiTiT
Copy link
Member

I was about to write that you can probably keep "Attributes that will be added to the baked alembic camera.", if it's true statement, but it is already gone.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Mar 26, 2024

I was about to write that you can probably keep "Attributes that will be added to the baked alembic camera.", if it's true statement, but it is already gone.

The issues was that it showed in the frontend as "global" header description for the full plug-in, instead of for that particular settings field. I've now moved whatever 'info' it contained that was lacking in the description into the description.

Happy to revert if you prefer the old.

@mkolar
Copy link
Member

mkolar commented Mar 27, 2024

I'd merge it, a lot of talk over a small pr :D

@mkolar mkolar merged commit 8923e75 into ynput:develop Mar 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members host: Maya size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants