-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maya Settings: Extract Camera bake attributes title fix + add description #220
Maya Settings: Extract Camera bake attributes title fix + add description #220
Conversation
The settings field is currently a string that should be a Maybe @iLLiCiTiT can elaborate on how we might be able to do so with backwards compatibility (like using settings conversions?) Also, we might want to remove the settings docstring which apparently is for this bake attributes and use that as the field's description instead. Thoughts on moving that @Innders ? (It'd make it the tooltip instead of being in the top bar) |
I'm wondering if a "?" button that can either be clicked or hovered to reveal a tooltip would be better. Otherwise it's not obvious there's extra info to see. |
Having a question mark icon for now while there aren't too many attributes with tooltips I think could be nice. However, I think we should just try and work towards almost everything getting tooltip descriptions (and then at some point it's everywhere and the question mark might become redundant.) |
My first question would be: "Why it was json at first place?". Conversion on server is possible, but client code conversion might be complicated, with combination of new maya settings and old ayon-core (or openpype). Could that wait until maya client code is bound to the server addon? |
Sure can - this PR doesn't touch the fact that it's JSON - it just fixes the label "Base" to "Bake" and adds a description. Shall we also remove the docstring?
|
…attributes` to begin with
I've gone ahead and done this with fe8613b |
I was about to write that you can probably keep |
The issues was that it showed in the frontend as "global" header description for the full plug-in, instead of for that particular settings field. I've now moved whatever 'info' it contained that was lacking in the description into the description. Happy to revert if you prefer the old. |
I'd merge it, a lot of talk over a small pr :D |
Changelog Description
Settings for Maya Extract Camera "bake attributes" should now be labeled correctly and have a description.
Additional info
I did not bump the server addon version because it's cosmetics only for the settings. So it's fine it only starts showing in future releases.
Testing notes: