Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Move workfile utils functions to workfile pipeline code #239

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Moved should_start_last_workfile and should_workfile_tool_start from applications logic to workfile pipeline code.

Additional info

Both functions are pipeline related, are using core settings and should be available from anywhere. Because applications logic will be separate into addon this is the ideal change.

Testing notes:

  1. Last workfiles should be opened correctly.
  2. Showing of workfiles tool on startup should work too (not sure for which host integrations it really works?).

@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition size/S labels Mar 25, 2024
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.

Out of curiosity, what parts will stay in ayon-core and what parts will go to ayon-applications (assuming applications.py would go)

@iLLiCiTiT
Copy link
Member Author

Out of curiosity, what parts will stay in ayon-core and what parts will go to ayon-applications (assuming applications.py would go)

Only applications.py and some cli (extractenvironments).

@kalisp kalisp assigned iLLiCiTiT and unassigned kalisp Mar 26, 2024
@iLLiCiTiT iLLiCiTiT merged commit 22107e6 into develop Mar 26, 2024
11 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/workfiles-utils-in-workfiles-api branch March 26, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants