Tray: Connection timeout and update validations #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiborBatek
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Tray tool can validate if is required update of AYON bundle and asks to relogin if user credentials are not valid.
Additional info
The validation happens once per 5 minutes. The credentials check happens withing it. It is still not possible to re-login when inside host and the validation happens only once a 5 minutes, but better than nothing. The update dialog is shown only in production or staging mode.
Possible enhancements in this PR
Maybe we should show information dialog "Your credentials are not valid anymore. Please close all applications and login again." before the login dialog is showed.
Testing notes:
Updates detection
Relogin
ayon-core variant of ynput/OpenPype#6194