Maya: Update publish instances via CreateContext + use task attributes instead of folder attributes #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mes if needed - Also rely on task attributes for resolution and frame ranges instead of folder attributes
ynbot
added
size/XS
type: enhancement
|
This overlaps a tiny bit with #340 since it touches the resolution reset taking it from the task attributes. |
BigRoy
commented
Apr 3, 2024
Comment on lines
+3252
to
+3283
| instance_values = { | ||
| "folderPath": create_context.get_current_folder_path(), | ||
| "task": create_context.get_current_task_name(), | ||
| } | ||
| creator_attribute_values = { | ||
| "frameStart": folder_entity["attrib"]["frameStart"], | ||
| "frameEnd": folder_entity["attrib"]["frameEnd"], | ||
| } | ||
|
|
||
| has_changes = False | ||
| for instance in create_context.instances: | ||
| for key, value in instance_values.items(): | ||
| if key not in instance or instance[key] == value: | ||
| continue | ||
|
|
||
| # Update instance value | ||
| print(f"Updating {instance.product_name} {key} to: {value}") | ||
| instance[key] = value | ||
| has_changes = True | ||
|
|
||
| creator_attributes = instance.creator_attributes | ||
| for key, value in creator_attribute_values.items(): | ||
| if ( | ||
| key not in creator_attributes | ||
| or creator_attributes[key] == value | ||
| ): | ||
| continue | ||
|
|
||
| # Update instance creator attribute value | ||
| print(f"Updating {instance.product_name} {key} to: {value}") | ||
| instance[key] = value | ||
| has_changes = True |
There was a problem hiding this comment.
Any code style tips for this @iLLiCiTiT ? Not sure if the two for loops feel cluttered or whether this makes sense as it is.
This was referenced Apr 3, 2024
moonyuet
approved these changes
Apr 3, 2024
LiborBatek
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Update instances using
CreateContextto correctly update product names if neededAdditional info
This will fix the updating the the workfile product name when switching between tasks and 'updating publish instances' along.
Testing notes: