Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maya: Improve validate node ids unique report #364

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Maya: Improve validate node ids unique report #364

merged 3 commits into from
Apr 5, 2024

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Apr 3, 2024

Changelog Description

Improve logs and readability of the report for unique node id validation.

Additional info

n/a

Testing notes:

  1. Nodes with the same cbId should be reported better in the validation report.

@BigRoy BigRoy requested a review from LiborBatek April 3, 2024 18:12
@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition size/XS host: Maya labels Apr 3, 2024
LiborBatek
LiborBatek approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems fine to me and working ok. The Select invalid and Repair actions works as intended too.

image

@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Apr 5, 2024
@kalisp kalisp merged commit 83e9b38 into ynput:develop Apr 5, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalisp kalisp kalisp approved these changes

@LiborBatek LiborBatek LiborBatek approved these changes

Assignees
No one assigned
Labels
community Issues and PRs coming from the community members host: Maya size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BigRoy @kalisp @LiborBatek @MustafaJafar @ynbot