Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: Collect Look code cleanup + minor bugfix #365

Merged
merged 7 commits into from
Apr 10, 2024

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Apr 3, 2024

Changelog Description

  • Fix: remove from list while iterating over a copy - fixes potential wrong removal from the list of the node types in RENDER_SET_TYPES
  • Remove redundant code
    • Remove unused maketx attribute on the class
    • Remove duplicate query of instance_lookup variable.
  • Restructure code for readability + improve docstrings

Additional info

Mostly cleanup.

Testing notes:

  1. Maya Collect Look should still work
  2. Maya Collect Model Render Sets (materials on model publish) should still work for non-shading engines (e.g. object sets)

@ynbot ynbot added size/S type: enhancement Improvement of existing functionality or minor addition host: Maya labels Apr 3, 2024
@BigRoy BigRoy requested a review from LiborBatek April 3, 2024 19:50
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working ok when publishing the Look and without any issues. Also added some test maya set with arnold properties...

And when loaded look on the asset:

Screenshot 2024-04-04 163117

Co-authored-by: Kayla Man <64118225+moonyuet@users.noreply.github.com>
@mkolar
Copy link
Member

mkolar commented Apr 9, 2024

@antirotor mergable?

Copy link
Member

@tokejepsen tokejepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully in Maya 2023.

@tokejepsen tokejepsen merged commit cff14e7 into ynput:develop Apr 10, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Maya size/S type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants