Workfiles tool: Fix update of context change

[iLLiCiTiT]

Changelog Description

Context change is propagated correctly, because controller of workfiles tool does capture it correctly.

Additional info

Change the context also in controller, and unify the context change into single method. Removed reset of controller on save as ( I'm not sure why the reset was there, probably only to update current context?).

How to replicate (maybe)

1. Launch DCC -> Task 1.
2. Open workfiles tool.
3. Keep folder, and change task and open workfile. Must be Open not Save as. -> Task 2
4. Check current context in AYON menu
5. Open workfiles tool again.
6. Again keep folder, change task back to the first one. -> Task 1
7. Context in AYON menu should show context of Task 2

Testing notes:

1. Workfile opened in same folder, but different task will change the context.

Resolves #180

[BigRoy]

Followed the testing notes and seemed to work fine in Maya, Houdini and Fusion.
However, I'm not entirely sure how to reproduce the actual bug this is trying to fix that would exist without this PR.

[BigRoy]

Seems to work fine in Maya, Houdini and Fusion. However see my comment - not sure what this fixes.

[MustafaJafar]

Tested in Houdini.. works fine.

I wonder if it fixes this issue #180
I tried replicating the issue but it seems it's fixed.

[iLLiCiTiT]

Modified the steps a little. With them I was able to replicate the issue consistently.

Opened maya on animation task > open workfile on generic > open workfile on animation. Global context is still on generic.

[BigRoy]

I could not reproduce this in develop initially. I had a feeling that somehow the issue was actually related to the scene file you're opening and that it's maybe reading the "context" from the OpenPypeContext metadata that might be saved in the scene.

So what I did was save the modeling scene into lighting WITHOUT updating the context data (e.g. do not update create context, just save the file there without publisher reset, etc.). Then in develop indeed I get the issue that changing task would somehow not be at the right context.

However note that I could also reproduce that when that file was saved to another folder - not just the task change.

[BigRoy]

As such I think the ACTUAL issue isn't the resetting to match with the current context - but the fact that we're somehow allowing to rely on the 'workfile' metadata to be the ground truth for that particular context and allowing it to override the actual session's context.

So even though this workaround PR works - there apparently still is some logic somewhere where "resetting" means resetting it to the invalid context.

Anyway, with this PR I was unable to intentionally try and break it - so I guess it's safe for now :D

[MustafaJafar]

Anyway, with this PR I was unable to intentionally try and break it - so I guess it's safe for now :D

same here.