Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Houdini: Transfer Render Targets settings from pre create to instance when creating ROP instances #385

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Houdini: Transfer Render Targets settings from pre create to instance when creating ROP instances #385

merged 2 commits into from
Apr 9, 2024

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Apr 9, 2024

Changelog Description

Transfer the render target setting from pre-create data to instance data, making sure the setting in the creator tab aligning to that in the publish tab

Additional info

n/a

Testing notes:

  1. Create ROP instance
  2. Choose your preferred render option(local, farm)
  3. Go to Publish Tab and check the related setting
  4. It should be aligned with what you set in the creator.

@ynbot ynbot added size/XS type: enhancement Improvement of existing functionality or minor addition host: Houdini labels Apr 9, 2024
@moonyuet moonyuet changed the title Transfer settings from pre create to instance Houdini: Transfer Render Targets settings from pre create to instance when creating ROP instances Apr 9, 2024
@moonyuet moonyuet mentioned this pull request Apr 9, 2024
Merged
MustafaJafar
MustafaJafar approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing this PR. I think we should transfer all precreate data to creator_attributes

@MustafaJafar MustafaJafar merged commit a894a9a into enhancement/AY-1009_Houdini-Local-Rendering Apr 9, 2024
2 checks passed
@MustafaJafar MustafaJafar deleted the enhancement/transfer_render_target_setting_from_pre_create_to_instance branch April 9, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MustafaJafar MustafaJafar MustafaJafar approved these changes

Assignees

@MustafaJafar MustafaJafar

Labels
host: Houdini size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moonyuet @MustafaJafar @ynbot