Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Small code cleanup #394

Merged
merged 9 commits into from
Apr 11, 2024
Merged

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Small code cleanup. Mark unused variables and imports that have purpose to be ignored by linters, or removed the variables. Added imported variables to __all__. Converted lambda to function. Use better variable naming.

Additional info

PR related to #196.

Testing notes:

  1. Logic did not change. Validate if it's true.

@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition host: TrayPublisher host: UE size/XS labels Apr 10, 2024
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test - but changes look good to me.

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
@iLLiCiTiT iLLiCiTiT merged commit 95b4d64 into develop Apr 11, 2024
1 check failed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/small-code-cleanup branch April 11, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: TrayPublisher host: UE size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants