Abstract Render Collector: Preserve instance id when replacing with new instance #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLLiCiTiT
reviewed
Apr 11, 2024
iLLiCiTiT
reviewed
Apr 11, 2024
iLLiCiTiT
reviewed
Apr 11, 2024
iLLiCiTiT
reviewed
Apr 11, 2024
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
iLLiCiTiT
reviewed
Apr 11, 2024
iLLiCiTiT
reviewed
Apr 11, 2024
iLLiCiTiT
reviewed
Apr 11, 2024
BigRoy
commented
Apr 11, 2024
|
I am missing |
Original `instance` variable might shadow wanted `render-like` instance if wrong order of instances get processed.
…b.com/BigRoy/ayon-core into chore/cleanup_abstract_collect_render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
The abstract render collector converts a Render Instance and adds it to the publishing context, but for After Effects and Fusion these "replaced" existing instances (
pyblish.api.Instance). However, by nature of removing the original instance and adding a new one this basically meant that now the new instance would not inherit the original instance's id and thus any logs generated on the original instance being replaced would not show in the publisher UI for the new instance.This PR changes it so that it doesn't replace the original instance at all - but just updates the source instance with the data from the render instance's data.
Additional info
This implements a different fix as was implemented in this PR #217
Testing notes: