Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workfile Templates: Delete placeholder if Keep Placeholder is not enabled #428

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Apr 17, 2024

Changelog Description

If a load placeholder plugin did not end up loading any content it would not be removed when Keep Placeholder was disabled.

Additional info

Extracted from #327

Testing notes:

  1. Build a workfile template with a load placeholder that does not load anything
  2. Make sure the template is build with Keep Placeholders OFF.
  3. The placeholder should be deleted after the build.

@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition size/XS labels Apr 17, 2024
@iLLiCiTiT iLLiCiTiT merged commit 8757051 into ynput:develop Apr 18, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants