Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: Bake Complex Animation export in FBX format #431

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Apr 18, 2024

Changelog Description

This PR is to fix the defined type of Bake Complex Animation being wrong in fbx.py which confuses the system not exporting the animation without baking. Besides, the exported rig/animation is broken if we add constraint as export options and this PR is to fix the bug of animation being exported correctly.
Also, this PR would add joint as validating options to ensure the joints are also being validated and not errored out the validator ValidateAnimatedReferences.

Additional info

See ynput/OpenPype#5589 which explains how the sets are purposed to do

Testing notes:

Rig Family:

  1. Launch Maya via launcher
  2. Create Rig Instance
  3. Attach your rigs and geometries to out_set & controls_set as usual
  4. Attach your control rigs and/or meshes into skeletonMesh_SET
  5. Attach your control rigs into skeletonAnim_SET
  6. Publish

Animation Family:

  1. Doing all the steps with "Rig Family" testing notes above
  2. Load your rigs
  3. Animate your rigs
  4. Click "Publish...." via Menu
  5. Publish along with the animation family

@ynbot ynbot added host: Maya type: enhancement Improvement of existing functionality or minor addition size/XS labels Apr 18, 2024
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test - but change makes sense.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...did follow all the testing steps resulting into published alembic and FBX animation, also checked with other DCC (blender) if animation outputted correctly...all good imho.

Screenshot 2024-04-18 144715

Screenshot 2024-04-18 144738

Screenshot 2024-04-18 144659

@moonyuet
Copy link
Member Author

@antirotor can you perform some test from your file to see if it fixes the issue?

@tokejepsen tokejepsen assigned antirotor and unassigned LiborBatek Apr 29, 2024
@moonyuet moonyuet added the sponsored This is directly sponsored by a client or community member label May 9, 2024
@ynbot
Copy link
Contributor

ynbot commented May 9, 2024

…ancement/AY-5073_Baking-animation-to-joins-during-the-publishing
…ancement/AY-5073_Baking-animation-to-joins-during-the-publishing
@moonyuet moonyuet changed the title Maya: Bake Complex Animation should be boolean option Maya: Bake Complex Animation export in FBX format May 13, 2024
@moonyuet moonyuet merged commit 4c163d4 into develop May 14, 2024
9 checks passed
@moonyuet moonyuet deleted the enhancement/AY-5073_Baking-animation-to-joins-during-the-publishing branch May 14, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Maya size/XS sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants