-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maya: Bake Complex Animation export in FBX format #431
Merged
moonyuet
merged 9 commits into
develop
from
enhancement/AY-5073_Baking-animation-to-joins-during-the-publishing
May 14, 2024
Merged
Maya: Bake Complex Animation export in FBX format #431
moonyuet
merged 9 commits into
develop
from
enhancement/AY-5073_Baking-animation-to-joins-during-the-publishing
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
host: Maya
type: enhancement
Improvement of existing functionality or minor addition
size/XS
labels
Apr 18, 2024
BigRoy
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test - but change makes sense.
LiborBatek
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antirotor can you perform some test from your file to see if it fixes the issue? |
moonyuet
added
the
sponsored
This is directly sponsored by a client or community member
label
May 9, 2024
…ancement/AY-5073_Baking-animation-to-joins-during-the-publishing
…ancement/AY-5073_Baking-animation-to-joins-during-the-publishing
…esn't get resample when it is exported
BigRoy
reviewed
May 10, 2024
BigRoy
reviewed
May 13, 2024
client/ayon_core/hosts/maya/plugins/publish/extract_fbx_animation.py
Outdated
Show resolved
Hide resolved
client/ayon_core/hosts/maya/plugins/publish/validate_animated_reference.py
Outdated
Show resolved
Hide resolved
moonyuet
changed the title
Maya: Bake Complex Animation should be boolean option
Maya: Bake Complex Animation export in FBX format
May 13, 2024
moonyuet
deleted the
enhancement/AY-5073_Baking-animation-to-joins-during-the-publishing
branch
May 14, 2024 05:56
BigRoy
reviewed
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
host: Maya
size/XS
sponsored
This is directly sponsored by a client or community member
type: enhancement
Improvement of existing functionality or minor addition
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This PR is to fix the defined type of
Bake Complex Animation
being wrong infbx.py
which confuses the system not exporting the animation without baking. Besides, the exported rig/animation is broken if we add constraint as export options and this PR is to fix the bug of animation being exported correctly.Also, this PR would add joint as validating options to ensure the joints are also being validated and not errored out the validator
ValidateAnimatedReferences
.Additional info
See ynput/OpenPype#5589 which explains how the sets are purposed to do
Testing notes:
Rig Family:
skeletonMesh_SET
skeletonAnim_SET
Animation Family: