-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maya: Refactor and implement fixes for Load Placeholder #436
Merged
antirotor
merged 11 commits into
ynput:develop
from
BigRoy:enhancement/maya_workfile_templates_refactor
May 3, 2024
Merged
Maya: Refactor and implement fixes for Load Placeholder #436
antirotor
merged 11 commits into
ynput:develop
from
BigRoy:enhancement/maya_workfile_templates_refactor
May 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hancement/maya_workfile_templates_refactor
- Implement fixes for outliner order of loaded placeholders (always place after placeholder) - Allow storing more complex data, e.g. EnumDef with multiselection=True - Change in behavior: This may fix a bug where previously placeholders may sometimes load only one subset when it should have loaded more. It could thus influence the loading behavior on existing templates - Implements a PlaceholderPlugin base class to be used by others potential plug-ins
ynbot
added
type: enhancement
Improvement of existing functionality or minor addition
host: After Effects
host: Maya
host: Nuke
size/XXL
labels
Apr 19, 2024
This was referenced Apr 19, 2024
…hancement/maya_workfile_templates_refactor
…ancement/maya_workfile_templates_refactor # Conflicts: # client/ayon_core/hosts/maya/api/workfile_template_builder.py
…_workfile_templates_refactor # Conflicts: # client/ayon_core/hosts/maya/api/workfile_template_builder.py # client/ayon_core/hosts/maya/plugins/workfile_build/load_placeholder.py
…ancement/maya_workfile_templates_refactor # Conflicts: # client/ayon_core/hosts/maya/plugins/workfile_build/load_placeholder.py
LiborBatek
approved these changes
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
antirotor
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
host: Maya
host: Nuke
size/XXL
type: enhancement
Improvement of existing functionality or minor addition
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Refactor Maya load placeholder, fixes:
Additional info
This PR depends on #425
I'll leave it in draft until that PR is merged because the changelog will now appear very big.
Testing notes: