Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: Refactor and implement fixes for Load Placeholder #436

Merged

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Apr 19, 2024

Changelog Description

Refactor Maya load placeholder, fixes:

  • Implement fixes for outliner order of loaded placeholders (always place after placeholder)
  • Allow storing more complex data, e.g. EnumDef with multiselection=True
  • Change in behavior: This may fix a bug where previously placeholders may sometimes load only one subset when it should have loaded more. It could thus influence the loading behavior on existing templates
  • Implements a PlaceholderPlugin base class to be used by others potential plug-ins

Additional info

This PR depends on #425

I'll leave it in draft until that PR is merged because the changelog will now appear very big.

Testing notes:

  1. Maya Workfile templates should still work
  2. Loading maya workfile templates should put the loaded products correctly next to the placeholder

- Implement fixes for outliner order of loaded placeholders (always place after placeholder)
- Allow storing more complex data, e.g. EnumDef with multiselection=True
- Change in behavior: This may fix a bug where previously placeholders may sometimes load only one subset when it should have loaded more. It could thus influence the loading behavior on existing templates
- Implements a PlaceholderPlugin base class to be used by others potential plug-ins
…ancement/maya_workfile_templates_refactor

# Conflicts:
#	client/ayon_core/hosts/maya/api/workfile_template_builder.py
…_workfile_templates_refactor

# Conflicts:
#	client/ayon_core/hosts/maya/api/workfile_template_builder.py
#	client/ayon_core/hosts/maya/plugins/workfile_build/load_placeholder.py
@BigRoy BigRoy marked this pull request as ready for review April 30, 2024 10:55
…ancement/maya_workfile_templates_refactor

# Conflicts:
#	client/ayon_core/hosts/maya/plugins/workfile_build/load_placeholder.py
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did tests and all seems working normally...

My workfile got populated according to my placeholders. I have also tested the updating of the workfile from template and all seem working ok.

image

@antirotor antirotor merged commit cf9a27e into ynput:develop May 3, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Maya host: Nuke size/XXL type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants