Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nuke: Publish intermediate files on demand #501

Merged
merged 3 commits into from
May 17, 2024
Merged

Nuke: Publish intermediate files on demand #501

merged 3 commits into from
May 17, 2024

Conversation

tokejepsen
Copy link
Member

Changelog Description

Intermediate files from the baking of LUTs in Nuke can be published with this PR.

Testing notes:

  1. Enable the Publish toggle on the outputs; ayon+settings://nuke/publish/ExtractReviewIntermediates/outputs/0/publish
  2. Publish a render in Nuke.
  3. Validate the output of the intermediate files are in the Loader on the products representations.

@ynbot
Copy link
Contributor

ynbot commented May 9, 2024

Task linked: AY-5269 Nuke: Publish intermediate files

@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition host: Nuke size/XS labels May 9, 2024
jakubjezek001
jakubjezek001 approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be ok, but since there is an issue with click module failing I was not able to test it. I would merge it since it looks ok and not sure what could be wrong with the implementation.

jakubjezek001
jakubjezek001 approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works only if #519 is merged.

@jakubjezek001 jakubjezek001 changed the title Nuke: Publish intermediate files Nuke: Publish intermediate files on demand May 16, 2024
@jakubjezek001 jakubjezek001 merged commit 8814924 into develop May 17, 2024
1 check passed
@jakubjezek001 jakubjezek001 deleted the enhancement/AY-5269_Nuke--Publish-intermediate-files branch May 17, 2024 10:38
@jakubjezek001 jakubjezek001 mentioned this pull request May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

Assignees

@jakubjezek001 jakubjezek001

Labels
host: Nuke size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tokejepsen @ynbot @jakubjezek001