Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorspace: Enhancement of subprocess getters #519

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Move all colorspace logic to colorspace.py which is only imported in ocio wrapper.

Additional info

Wrapper is now just simple cli that calls functions from colorspace and stores result into output json. Code from wrapper was moved to colorspace.py. Moved functions areound, deprecated functions are at the bottom.
Validation of compatible PyOpenColorIO now also checks version of the module.

Testing notes:

  1. Colorspace logic should work almost anywhere.

@ynbot
Copy link
Contributor

ynbot commented May 15, 2024

@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition size/L labels May 15, 2024
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Traceback (most recent call last):
  File "C:\CODE\__PYPE\ayon-core\client\ayon_core\tools\launcher\models\actions.py", line 400, in trigger_action
    action.process(selection)
  File "C:\CODE\__PYPE\ayon-core\client\ayon_core\tools\launcher\models\actions.py", line 119, in process
    self.application.launch(
  File "C:\Users\jakub\AppData\Local\Ynput\AYON\addons\applications_0.2.2\ayon_applications\defs.py", line 298, in launch
    return self.manager.launch(self.full_name, *args, **kwargs)
  File "C:\Users\jakub\AppData\Local\Ynput\AYON\addons\applications_0.2.2\ayon_applications\manager.py", line 173, in launch
    return self.launch_with_context(context)
  File "C:\Users\jakub\AppData\Local\Ynput\AYON\addons\applications_0.2.2\ayon_applications\manager.py", line 149, in launch_with_context
    return launch_context.launch()
  File "C:\Users\jakub\AppData\Local\Ynput\AYON\addons\applications_0.2.2\ayon_applications\manager.py", line 597, in launch
    self.run_prelaunch_hooks()
  File "C:\Users\jakub\AppData\Local\Ynput\AYON\addons\applications_0.2.2\ayon_applications\manager.py", line 581, in run_prelaunch_hooks
    prelaunch_hook.execute()
  File "C:\CODE\__PYPE\ayon-core\client\ayon_core\hooks\pre_ocio_hook.py", line 39, in execute
    config_data = get_imageio_config_preset(
  File "C:\CODE\__PYPE\ayon-core\client\ayon_core\pipeline\colorspace.py", line 968, in get_imageio_config_preset
    config_data = _get_global_config_data(
  File "C:\CODE\__PYPE\ayon-core\client\ayon_core\pipeline\colorspace.py", line 750, in _get_global_config_data
    imageio_global[ "ocio_config_profiles" ], filter_values

Update:

This was caused by older settings in imageio. Fixed by uprating core addon server settigns

@jakubjezek001 jakubjezek001 self-requested a review May 16, 2024 13:01
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as it should

@iLLiCiTiT iLLiCiTiT merged commit cb95591 into develop May 16, 2024
5 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/AY-5366_Colorspace-enhancement-of-subprocess-getters branch May 16, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants