Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke: fixing multiple intermediate file streams publishing #531

Merged
merged 2 commits into from
May 28, 2024

Conversation

jakubjezek001
Copy link
Member

Changelog Description

  • Update colorspace assignment to use a method
  • Remove redundant line adding custom tags - it was blocking Extract review transcoding.

Testing notes:

  1. create multiple presets in ayon+settings://nuke/publish/ExtractReviewIntermediates/outputs
  2. publish files and notice that multiple mp4 were created.

…necessary line adding custom tags in ExtractReviewIntermediates class.

- Update colorspace assignment to use a method
- Remove redundant line adding custom tags
@ynbot ynbot added size/XS type: bug Something isn't working host: Nuke labels May 20, 2024
@jakubjezek001 jakubjezek001 changed the title Update colorspace assignment in ExporterReviewMov class and remove unnecessary line adding custom tags in ExtractReviewIntermediates class. Nuke: fixing multiple intermediate file streams publishing May 20, 2024
@64qam 64qam requested a review from MilaKudr May 24, 2024 08:51
@64qam
Copy link
Member

64qam commented May 24, 2024

Crashes on Extract Review Intermediates:

Traceback (most recent call last):
  File "C:\Users\qam\AppData\Local\Ynput\AYON\dependency_packages\ayon_2403071252_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "C:\Users\qam\AppData\Local\Ynput\AYON\addons\core_0.3.3-dev.1\ayon_core\hosts\nuke\plugins\publish\extract_review_intermediates.py", line 162, in process
    data = exporter.generate_mov(delete=delete, **o_data)
  File "C:\Users\qam\AppData\Local\Ynput\AYON\addons\core_0.3.3-dev.1\ayon_core\hosts\nuke\api\plugin.py", line 990, in generate_mov
    self.render(write_node.name())
  File "C:\Users\qam\AppData\Local\Ynput\AYON\addons\core_0.3.3-dev.1\ayon_core\hosts\nuke\api\plugin.py", line 820, in render
    int(self.last_frame))
RuntimeError: Write1: the selected codec is not supported in this container.```

[publish-report-240524-16-14.json](https://github.com/ynput/ayon-core/files/15435746/publish-report-240524-16-14.json)

@MilaKudr
Copy link

This PR works in my environment. Publishing locally and on Deadline works properly, also delivering to the Kitsu.

@jakubjezek001 jakubjezek001 merged commit c289610 into develop May 28, 2024
1 check passed
@jakubjezek001 jakubjezek001 deleted the bugfix/nuke-intermediate-steams-bugs branch May 28, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Nuke size/XS type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants