Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish representation with isIntermediate flag in data #551

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented May 24, 2024

Changelog Description

Publish intermediate file representation with isIntermediate flag in data

Additional info

  • Adjusted method parameters in ExporterReview class for better readability.
  • Added colorspace parameter to get_representation_data method.

Testing notes:

  1. in Nuke activate ayon+settings://nuke/publish/ExtractReviewIntermediates/outputs/0/publish
  2. in Nuke publish normal render product type and capture published representation id from integrate.py plugin log.
  3. Open AYON console from Tray and use following snippet to check the data of published representation.
from pprint import pprint
from ayon_api import get_representation_by_id

repre = get_representation_by_id(
    [YOUR PROJECT NAME], [PUBLISHED_REPRE_ID],)

pprint(repre)
  1. you should be able to find isIntermediate flag within the repre document data keys.

this is follower for #501

- Adjusted method parameters in ExporterReview class for better readability.
- Added colorspace parameter to get_representation_data method.
- Included representation data with isIntermediate flag for identifying intermediate files.
@ynbot
Copy link
Contributor

ynbot commented May 24, 2024

Task linked: AY-5269 Nuke: Publish intermediate files

@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition host: Nuke size/XS labels May 24, 2024
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully in nuke and our console.
image
image

@kalisp
Copy link
Member

kalisp commented May 24, 2024

Why won't we use tag for it? Or maybe I am misunderstanding use case.

@kalisp kalisp assigned jakubjezek001 and unassigned kalisp May 28, 2024
@jakubjezek001 jakubjezek001 merged commit 205db2e into develop May 28, 2024
1 check passed
@jakubjezek001 jakubjezek001 deleted the enhancement/AY-5269_Nuke--Publish-intermediate-files-publish-isIntermediate branch May 28, 2024 10:33
@BigRoy
Copy link
Collaborator

BigRoy commented May 28, 2024

Why won't we use tag for it? Or maybe I am misunderstanding use case.

I actually had the same question in my mind as @kalisp had there. @jakubjezek001 could you elaborate a bit on that?

@jakubjezek001
Copy link
Member Author

Tags are used only when we publish, and they're not part of the database document. We need to fetch the flagged data from the database during delivery-related tasks.

@BigRoy
Copy link
Collaborator

BigRoy commented Jun 3, 2024

Tags are used only when we publish, and they're not part of the database document. We need to fetch the flagged data from the database during delivery-related tasks.

Sorry - isn't it the case that we're able to add data["tags"] = ["intermediate"] even on the representation? That's what we're asking, right?

Also, I thought having actual supported tags per representation on a lower level already so that in the database we can actually tag things as well (or does it only exist like that on folders?)

The question kind of is - couldn't this be a tag on the representation or whatever. Or does this mean that we might end up flooding with arbitrary data again on the representations that we do start to rely on elsewhere (e.g. in deliveries) that we do not want to be as fluid but prefer to make more strict, almost like attributes or tags, etc. over time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Nuke size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants