Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke: Support options for reading deep exr in load clips #555

Merged
merged 3 commits into from
May 27, 2024

Conversation

moonyuet
Copy link
Member

Changelog Description

This PR is to add the support of reading deep exr in load clips. Users can choose to turn on/off of reading the deep exr node. By default is False.

Additional info

Make sure you have built the latest nuke addon for this support.

Testing notes:

  1. Go to ayon+settings://nuke/load/LoadClip/options_defaults/deep_exr to turn on the toggle
  2. Or you can choose the options through AYON->Load... after launching Nuke
    image
    image
  3. Load the clips
  4. The deep read node should be used for loading clip while the deep exr option turns on. The read node should be used when the option turns off.

@ynbot
Copy link
Contributor

ynbot commented May 27, 2024

Task linked: AY-5543 nuke: deep exr loading

@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition size/XS host: Nuke labels May 27, 2024
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved by mistake

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue is that colorspace knob DeepLoader class doesn't exists.
image

Traceback (most recent call last):
  File "C:\CODE\__PYPE\ayon-core\client\ayon_core\tools\loader\models\actions.py", line 740, in _load_representations_by_loader
    load_with_repre_context(
  File "C:\CODE\__PYPE\ayon-core\client\ayon_core\pipeline\load\utils.py", line 323, in load_with_repre_context
    return loader.load(repre_context, name, namespace, options)
  File "C:\CODE\__PYPE\ayon-core\client\ayon_core\hosts\nuke\plugins\load\load_clip.py", line 192, in load
    self.set_colorspace_to_node(
  File "C:\CODE\__PYPE\ayon-core\client\ayon_core\hosts\nuke\plugins\load\load_clip.py", line 418, in set_colorspace_to_node
    and colorspace_exists_on_node(read_node, used_colorspace)
  File "C:\CODE\__PYPE\ayon-core\client\ayon_core\hosts\nuke\api\utils.py", line 110, in colorspace_exists_on_node
    colorspace_knob = node['colorspace']
NameError: knob colorspace does not exist

@moonyuet
Copy link
Member Author

Issue is that colorspace knob DeepLoader class doesn't exists. image

Traceback (most recent call last):
  File "C:\CODE\__PYPE\ayon-core\client\ayon_core\tools\loader\models\actions.py", line 740, in _load_representations_by_loader
    load_with_repre_context(
  File "C:\CODE\__PYPE\ayon-core\client\ayon_core\pipeline\load\utils.py", line 323, in load_with_repre_context
    return loader.load(repre_context, name, namespace, options)
  File "C:\CODE\__PYPE\ayon-core\client\ayon_core\hosts\nuke\plugins\load\load_clip.py", line 192, in load
    self.set_colorspace_to_node(
  File "C:\CODE\__PYPE\ayon-core\client\ayon_core\hosts\nuke\plugins\load\load_clip.py", line 418, in set_colorspace_to_node
    and colorspace_exists_on_node(read_node, used_colorspace)
  File "C:\CODE\__PYPE\ayon-core\client\ayon_core\hosts\nuke\api\utils.py", line 110, in colorspace_exists_on_node
    colorspace_knob = node['colorspace']
NameError: knob colorspace does not exist

Fixed. Can you please test again? Thanks!

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all works fine now, thanks! ;)

@jakubjezek001 jakubjezek001 merged commit 646787a into develop May 27, 2024
1 check passed
@jakubjezek001 jakubjezek001 deleted the enhancement/AY-5543_nuke-deep-exr-loading branch May 27, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Nuke size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants