Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Move hiero client code #586

Merged
merged 13 commits into from
Jun 4, 2024
Merged

Chore: Move hiero client code #586

merged 13 commits into from
Jun 4, 2024

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jun 3, 2024 •
edited by jakubjezek001
Loading

Changelog Description

Moved Hiero client code next to server codebase.

Additional information

Removed settings of not available plugins ExtractReviewCutUpVideo and CollectInstanceVersion.
This PR is also adding fixes from #589

Testing notes:

  1. Create package of hiero and core.
  2. Upload both to server.
  3. Make sure AYON launcher is using client code from this PR (e.g using dev paths).
  4. Hiero integration should work as before.

@ynbot
Copy link
Contributor

ynbot commented Jun 3, 2024

Task linked: AY-4915 Move Hiero client code

@ynbot ynbot added size/S host: Fusion host: Houdini host: Maya host: Nuke type: enhancement Improvement of existing functionality or minor addition labels Jun 3, 2024
@iLLiCiTiT iLLiCiTiT changed the title Enhancement/ay 4915 move hiero client code Chore: Move hiero client code Jun 3, 2024
jakubjezek001
jakubjezek001 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the loader fix, the pr is working as it suppose to

@jakubjezek001 jakubjezek001 merged commit 00f19a4 into develop Jun 4, 2024
3 checks passed
@jakubjezek001 jakubjezek001 deleted the enhancement/AY-4915_Move-Hiero-client-code branch June 4, 2024 13:31
@jakubjezek001 jakubjezek001 mentioned this pull request Jun 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

Assignees

@jakubjezek001 jakubjezek001

Labels
size/S type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iLLiCiTiT @ynbot @jakubjezek001