Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Editorial does not use asset naming #592

Merged
merged 8 commits into from
Jun 10, 2024

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jun 4, 2024

Changelog Description

Use key "newHierarchyIntegration" instead of "newAssetPublishing".

Additional info

The value stored under the key defines that a new folder and tasks may be created. In that case folder entity and task entity may not be available.

Testing notes:

  1. All editorial integrations should work.

@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition host: Flame host: Resolve host: TrayPublisher labels Jun 4, 2024
@iLLiCiTiT iLLiCiTiT changed the title Chore: Editorial dos not use asset naming Chore: Editorial does not use asset naming Jun 4, 2024
@ynbot ynbot added the size/XS label Jun 4, 2024
@@ -676,6 +676,8 @@ def _get_base_instance_data(
"shotName": shot_name,
"variant": variant_name,
"task": None,
"newHierarchyIntegration": True,
# Backwards compatible
"newAssetPublishing": True,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we now start removing this older data key to ensure the new one does what we want it to do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can have new traypublisher addon and old ayon-core addon...

Copy link
Collaborator

@BigRoy BigRoy Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a remove backwards compatibility by version x.y.z label to the comment so we know when to remove it in the future? Or do we prepare an issue now to remind us in say 3 months?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you not make use of the package ayon_required_addons to force a minimum version?

Copy link
Member Author

@iLLiCiTiT iLLiCiTiT Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a remove backwards compatibility by version x.y.z label to the comment so we know when to remove it in the future? Or do we prepare an issue now to remind us in say 3 months?

At this moment specific version is too "wild" guess. But I guess we can add at least date when it "started" to be deprecated?

can you not make use of the package ayon_required_addons to force a minimum version?

You can, but core cannot (or should not). And at this moment we don't know about all unofficial addons using this.

@iLLiCiTiT iLLiCiTiT merged commit a36a4d5 into develop Jun 10, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/dont-use-asset-naming-in-editorial branch June 10, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Resolve host: TrayPublisher size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants