Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Use material symbols in UIs #593

Merged
merged 32 commits into from
Jun 17, 2024
Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jun 4, 2024

Changelog Description

Add material symbols to existing tools in ayon-core.

Additional info

Added qtmaterialsymbols custom implementation (similar to qtawesome) and use it in basic tools.

Screenshots

image

Testing notes:

  1. Tools should show same icons as AYON web UI does

@ynbot ynbot added type: feature Adding something new and exciting to the product size/XXL labels Jun 4, 2024
@BigRoy
Copy link
Collaborator

BigRoy commented Jun 5, 2024

Starting to look nice! :)

image

Also really like the folder and task icons.

image

They do appear slightly blurrier than the old ones though:

image

Maybe it's just not an optimal size usage for these icons?
Hard to tell also because the old ones basically had no detail whatsoever.


No icons in scene inventory yet though - but hey, this is still just a draft PR

image

@iLLiCiTiT iLLiCiTiT added the community Issues and PRs coming from the community members label Jun 6, 2024
@BigRoy
Copy link
Collaborator

BigRoy commented Jun 10, 2024

  • use status icon in combobox

  • add default behavior to simple folders and tasks widget

I believe these are now implemented? Or I'm not sure what these refer to.
What's needed for this PR to be ready for review?

@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Jun 10, 2024

What's needed for this PR to be ready for review?

Simple folders widget don't use icons (should be simple modification of SimpleFoldersController). And select version combobox in scene inventory does not paint the icon (selection popup does, but not the selected one).

@BigRoy
Copy link
Collaborator

BigRoy commented Jun 10, 2024

Traceback (most recent call last):
  File "E:\dev\ayon-core\client\ayon_core\tools\sceneinventory\view.py", line 309, in <lambda>
    lambda: self._show_version_dialog(item_ids, active_repre_id)
  File "E:\dev\ayon-core\client\ayon_core\tools\sceneinventory\view.py", line 746, in _show_version_dialog
    version_option = SelectVersionDialog.ask_for_version(
  File "E:\dev\ayon-core\client\ayon_core\tools\sceneinventory\select_version_dialog.py", line 215, in ask_for_version
    dialog.set_versions(version_options)
  File "E:\dev\ayon-core\client\ayon_core\tools\sceneinventory\select_version_dialog.py", line 207, in set_versions
    self._versions_combobox.set_versions(version_options)
  File "E:\dev\ayon-core\client\ayon_core\tools\sceneinventory\select_version_dialog.py", line 140, in set_versions
    icon = get_qt_icon({
  File "E:\dev\ayon-core\client\ayon_core\tools\utils\lib.py", line 563, in get_qt_icon
    return _IconsCache.get_icon(icon_def)
  File "E:\dev\ayon-core\client\ayon_core\tools\utils\lib.py", line 481, in get_icon
    cache_key = cls._get_cache_key(icon_def)
  File "E:\dev\ayon-core\client\ayon_core\tools\utils\lib.py", line 474, in _get_cache_key
    return "|".join(parts)
TypeError: sequence item 2: expected str instance, PySide2.QtGui.QColor found

Getting this error in Fusion also when clicking "Set version" in Scene Inventory. The pop-up dialog for setting versions does not show.

@BigRoy
Copy link
Collaborator

BigRoy commented Jun 10, 2024

This is now fixed with 909b6b9

But I'm now getting:

Traceback (most recent call last):
  File "E:\dev\ayon-core\client\ayon_core\tools\utils\delegates.py", line 223, in paint
    QtWidgets.QPalette.Normal
AttributeError: module 'qtpy.QtWidgets' has no attribute 'QPalette'

@iLLiCiTiT iLLiCiTiT marked this pull request as ready for review June 10, 2024 14:42
@BigRoy
Copy link
Collaborator

BigRoy commented Jun 10, 2024

Nice.

All works.

I do wonder if the combobox (main entry, not the list) needs more padding/margins:

image

@BigRoy
Copy link
Collaborator

BigRoy commented Jun 10, 2024

By the way, is the label "community contribution" correct on this PR?

@iLLiCiTiT
Copy link
Member Author

I do wonder if the combobox (main entry, not the list) needs more padding/margins:

Where did you take the screenshot?

image

By the way, is the label "community contribution" correct on this PR?

Yes, I do it in my free time.

@BigRoy
Copy link
Collaborator

BigRoy commented Jun 11, 2024

Where did you take the screenshot?

Good question! :)

This is in Maya 2024:

image

This is in Houdini 20.0.703:

image

This is in Fusion 18:

image

So I guess - ignore it?

@m-u-r-p-h-y m-u-r-p-h-y self-assigned this Jun 17, 2024
@LiborBatek LiborBatek self-requested a review June 17, 2024 12:02
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works fine. . .

image

@iLLiCiTiT iLLiCiTiT merged commit d79973d into develop Jun 17, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the feature/material-symbols-in-uis branch June 17, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members size/XXL type: feature Adding something new and exciting to the product
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants