-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools: Use material symbols in UIs #593
Conversation
Starting to look nice! :) Also really like the folder and task icons. They do appear slightly blurrier than the old ones though: Maybe it's just not an optimal size usage for these icons? No icons in scene inventory yet though - but hey, this is still just a draft PR |
I believe these are now implemented? Or I'm not sure what these refer to. |
Simple folders widget don't use icons (should be simple modification of |
Traceback (most recent call last):
File "E:\dev\ayon-core\client\ayon_core\tools\sceneinventory\view.py", line 309, in <lambda>
lambda: self._show_version_dialog(item_ids, active_repre_id)
File "E:\dev\ayon-core\client\ayon_core\tools\sceneinventory\view.py", line 746, in _show_version_dialog
version_option = SelectVersionDialog.ask_for_version(
File "E:\dev\ayon-core\client\ayon_core\tools\sceneinventory\select_version_dialog.py", line 215, in ask_for_version
dialog.set_versions(version_options)
File "E:\dev\ayon-core\client\ayon_core\tools\sceneinventory\select_version_dialog.py", line 207, in set_versions
self._versions_combobox.set_versions(version_options)
File "E:\dev\ayon-core\client\ayon_core\tools\sceneinventory\select_version_dialog.py", line 140, in set_versions
icon = get_qt_icon({
File "E:\dev\ayon-core\client\ayon_core\tools\utils\lib.py", line 563, in get_qt_icon
return _IconsCache.get_icon(icon_def)
File "E:\dev\ayon-core\client\ayon_core\tools\utils\lib.py", line 481, in get_icon
cache_key = cls._get_cache_key(icon_def)
File "E:\dev\ayon-core\client\ayon_core\tools\utils\lib.py", line 474, in _get_cache_key
return "|".join(parts)
TypeError: sequence item 2: expected str instance, PySide2.QtGui.QColor found Getting this error in Fusion also when clicking "Set version" in Scene Inventory. The pop-up dialog for setting versions does not show. |
# Conflicts: # client/ayon_core/tools/publisher/control.py
By the way, is the label "community contribution" correct on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog Description
Add material symbols to existing tools in ayon-core.
Additional info
Added
qtmaterialsymbols
custom implementation (similar toqtawesome
) and use it in basic tools.Screenshots
Testing notes: