Nuke: Enhance Viewer process override with colorspace, display-view #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actor ExtractReviewIntermediates settings.
Added ColorspaceConfigurationModel for baking target selection and override in various settings to enhance flexibility and customization.
…tion notice for 'Baking' setting in ImageIOSettings. - Update descriptions for 'View' and 'Colorspace' settings to include information about using Anatomy context tokens. - Add a deprecation notice for the 'Baking' setting in ImageIOSettings, recommending the use of 'Baking Target Colorspace'.
ynbot
added
size/S
host: Nuke
type: enhancement
…rocess-override-with-colorspace-display-view
Refactor settings conversions for better viewer configuration handling. - Added `_isGroup` attribute to models - Implemented functions to extract display and viewer from strings - Updated conversion functions for imageio settings
…rocess-override-with-colorspace-display-view
handle imageio_nuke dictionary, refactor ExporterReviewMov class to support different colorspaces for baking, and adjust settings in PublishPluginsModel.
Remove unused imports, refactor knob creation and updating functions, improve logging messages for better clarity, update
moonyuet
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
I tested with/without the colorspace override. Extract review can publish accordingly with or without colorspace override. When I loaded the mov back to the scene, the video appears to show my preferences of display and view with the colorspace override. It also stays with default Rec709 which can be set in baking target colorspace.
The left green read node is the one which publishes without enabling colorspace override, and the right one is with colorspace override enabled and setting the display as ACES, views as sRGB.
iLLiCiTiT
reviewed
Jun 14, 2024
iLLiCiTiT
reviewed
Jun 14, 2024
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
refactor functions for consistency.
…rocess-override-with-colorspace-display-view
jakubjezek001
deleted the
enhancement/AY-5270_Nuke-Enhance-Viewer-process-override-with-colorspace-display-view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This pull request addresses the limitations of the Baking preset Viewer process override input field. Previously, the field was restricted to accepting only display and view type names for presets, leading to potential confusion among users. With this update, we have expanded the functionality to include colorspace names, thereby enhancing the user experience and aligning with industry-standard practices.
Key Features Implemented:
The implementation has been thoroughly tested to confirm that it meets the desired specifications and behaves as expected across various scenarios. This enhancement is a step forward in our ongoing efforts to streamline our color management workflow and provide robust tools for our users.
Additional info
Some debug logging were removed and f-string conversions done
Testing notes:
To replicate this test case, ensure that the configuration with context-specific names is loaded within a Nuke task session. Reach out on Discord to coordinate a joint testing effort.