Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deadline: Move auth and verify to submit only #623

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Deadline: Move auth and verify to submit only #623

merged 5 commits into from
Jun 11, 2024

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Jun 10, 2024

Changelog Description

Submit method requires these two arguments, if one needs to override process_submission, they can get auth and verify themselves.

Testing notes:

  1. publish in Blender via DL
  2. publish in Max in DL
  3. publish in Maya in DL

@kalisp
Move auth and verify to submit only
6e487c6 
submit requires these two arguments, if one needs to override process_submission, they can get auth and verify themselves.
@kalisp kalisp requested a review from LiborBatek June 10, 2024 15:02
LiborBatek
LiborBatek approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have did all 3 hosts test with complete rendered image sequences and all of those worked flawlessly!

All good!

Screenshot 2024-06-11 091653

Screenshot 2024-06-11 092337

Screenshot 2024-06-11 092851

All of those DL jobs were sucessfully finnished and integrated with burnins too...

So I guess this fix is GOOD TO GO!

@kalisp kalisp requested a review from iLLiCiTiT June 11, 2024 10:08
@kalisp kalisp assigned iLLiCiTiT and unassigned LiborBatek Jun 11, 2024
@iLLiCiTiT iLLiCiTiT assigned kalisp and unassigned iLLiCiTiT Jun 11, 2024
@kalisp kalisp merged commit 6a77a30 into develop Jun 11, 2024
1 check passed
@kalisp kalisp deleted the bugfix/process_submission_arguments branch June 11, 2024 11:31
@BigRoy BigRoy mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiaserra fabiaserra fabiaserra left review comments

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

@LiborBatek LiborBatek LiborBatek approved these changes

Assignees

@kalisp kalisp

Labels
host: Maya host: 3dsmax module: Deadline size/XS type: bug Something isn't working
Projects
PR reviewing
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kalisp @fabiaserra @iLLiCiTiT @LiborBatek @ynbot