Collect Farm Target: Only report errors for not found addons if no valid farm addon found #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
size/XS
type: enhancement
…instance and doing nothing with it
kalisp
reviewed
Jun 11, 2024
kalisp
reviewed
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Only report errors for not found addons if no valid farm addon found
Additional info
Solved redundant error logs for e.g.
royalrenderaddon even if the studio isn't using it. Now it only logs errors for not found addons if NO valid farm addon is found at all.Avoids this error log if it's irrelevant:
These error logs were also visibile in screenshots here: #623 (review)
Testing notes:
Note that with this change if both Royal Render and Deadline are enabled addons that now Deadline takes precedence where with the old logic Royal Render would be picked.