-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Max: Bug fix the "remove items" not working in Scene Inventory Manager #66
Max: Bug fix the "remove items" not working in Scene Inventory Manager #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look ok, needs testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to work for max assets (max, abc representations) but fails when loading Abc products comming from different DCC like maya for some reason.
It generally removes the asset
from Scene Inventory
and also the asset container
but not remove the actual geometries
.
Not sure if desired aka should work either?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, double checked my bundles and core addon etc but cant make it working...
Neither native max assets works nor outside from other DCC host...assets not being removed after triggering Manage
and Remove
action.
Check my vid for details...
2024-02-22_09-11-05.mp4
@LiborBatek my bad, I guess I doesn't manage the branch well which leads to the implementation of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now all working fine!
Note: would be lovely to perform viewport update
after that Remove
so the asset(s) which being removed wont be present still in the viewport as they are now before triggering any viewport action by the user causing slight confusion right away.
All working as expected and without any glitch! |
@iLLiCiTiT @antirotor can you guys take a final glance before merging? Thank you! |
Changelog Description
When the users load the objects through loaders and they want to remove them in scene inventory manager, the function doesn't work as expected to remove all data. This PR is to ensure the removal of the objects by using remove items in scene inventory manager.
Additional info
n/a
Testing notes:
Launch Max with AYON
Load objects in any family
Go to Manage... to access Scene Inventory
Right Click to click "Remove items"
The objects and the data would be deleted as expected.