Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max: Bug fix the "remove items" not working in Scene Inventory Manager #66

Merged
merged 6 commits into from
Feb 22, 2024

Conversation

moonyuet
Copy link
Member

Changelog Description

When the users load the objects through loaders and they want to remove them in scene inventory manager, the function doesn't work as expected to remove all data. This PR is to ensure the removal of the objects by using remove items in scene inventory manager.

Additional info

n/a

Testing notes:

  1. Launch Max with AYON

  2. Load objects in any family

  3. Go to Manage... to access Scene Inventory

  4. Right Click to click "Remove items"
    image

  5. The objects and the data would be deleted as expected.

Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look ok, needs testing.

@m-u-r-p-h-y m-u-r-p-h-y self-assigned this Feb 20, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work for max assets (max, abc representations) but fails when loading Abc products comming from different DCC like maya for some reason.

It generally removes the asset from Scene Inventory and also the asset container but not remove the actual geometries.

Not sure if desired aka should work either?

Here is the outcome of Remove asset action :
image

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, double checked my bundles and core addon etc but cant make it working...

Neither native max assets works nor outside from other DCC host...assets not being removed after triggering Manage and Remove action.

Check my vid for details...

2024-02-22_09-11-05.mp4

@moonyuet
Copy link
Member Author

@LiborBatek my bad, I guess I doesn't manage the branch well which leads to the implementation of remove_container_data goes missing in each loader. It should be working now.

@m-u-r-p-h-y m-u-r-p-h-y assigned LiborBatek and unassigned moonyuet Feb 22, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now all working fine!

Note: would be lovely to perform viewport update after that Remove so the asset(s) which being removed wont be present still in the viewport as they are now before triggering any viewport action by the user causing slight confusion right away.

@LiborBatek
Copy link
Member

All working as expected and without any glitch!

@moonyuet
Copy link
Member Author

@iLLiCiTiT @antirotor can you guys take a final glance before merging? Thank you!

@m-u-r-p-h-y m-u-r-p-h-y assigned iLLiCiTiT and unassigned LiborBatek Feb 22, 2024
@iLLiCiTiT iLLiCiTiT merged commit f6e6042 into develop Feb 22, 2024
8 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/OP-8125_3dsmax-removing-item-in-manager branch February 22, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants