Tool UIs: Handle missing folder short name #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigRoy
reviewed
Jun 18, 2024
There was a problem hiding this comment.
Didn't test, but changes make sense for the described issue.
I did notice my projects have these as default values:
And I've not faced an issue before this PR with anything. The question then becomes, how do I get my project into such a state that it is an actual issue?
Comment on lines
+195
to
+197
| if thread.failed: | ||
| # TODO visualize that refresh failed | ||
| folder_items, folder_type_items = {}, {} |
There was a problem hiding this comment.
Can we do anything to reproduce this particular issue when the thread would fail?
There was a problem hiding this comment.
It may wary, could be because server connection failed, or like reason of this PR, missing key in data.
MilaKudr
approved these changes
Jun 18, 2024
64qam
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
It looks like
"shortName"does not have to be filled on project so safe access to the key was added.Additional info
Also added base handling of failed thread in folders widget to at least print exception.
Testing notes:
"shortName"in folder type should show folders in UIs.