Scene Inventory: Action to update to latest approved version #690
Conversation
|
Task linked: AY-5635 Action to update to latest approved version |
ynbot
added
size/S
type: feature
| return cls( | ||
| version_id=version_entity["id"], | ||
| product_id=version_entity["productId"], | ||
| version=version_entity["version"], | ||
| status=version_entity["status"], | ||
| is_latest=is_latest, | ||
| is_last_approved=is_last_approved, |
There was a problem hiding this comment.
Is it odd that we call the state done but here refer to it as approved. Should we rename this is_last_done?
Admittedly, that's a confusing name - but at least it's referring to the same thing. Or, we refactor the status name from done to approved so it matches with this?
There was a problem hiding this comment.
It should really care about last approved, how the value is filled might change in future.
NOTE: We had a long discussion about how to define "last approved" (or just "approved") and came to conclusion that it might change in future with more specific settings.
m-u-r-p-h-y
added
the
sponsored
|
I like it - but now I start to definitely want to have a "set default status on publish" (settings) and "choose publish status in publisher" (publisher attribute per instance) implementations 🗡️ |
iLLiCiTiT
force-pushed
the
feature/AY-5635_Action-to-update-to-latest-approved-version
branch
from
8864b06
to
403442b
Compare
…t-approved-version
iLLiCiTiT
deleted the
feature/AY-5635_Action-to-update-to-latest-approved-version
branch
Changelog Description
Scene inventory tool now can update to latest approved version.
Additional info
This is a proposal how it could be implemented, we still need to modify validator which checks versions of loaded containers. The latest approved version is determined by Status "state" which has 4 options
"not_started","in_progress","done"and"blocked. We use"done".FunctionRevertedget_outdated_containersnow does not mark last approved as outdated > not sure if this is an issue or enhancement?Testing notes: