Global: dirmap for non local nor studio sites #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Site Sync addon throws ValueError for no local/studio sites as it doesn't make sense to override roots for sftp or gdrive. This handles gracefully this exception.
iLLiCiTiT
reviewed
Jul 5, 2024
client/ayon_core/host/dirmap.py
Outdated
Comment on lines
222
to
223
| def _get_site_root_overrides( | ||
| self, sitesync_addon, project_name, site_name): |
There was a problem hiding this comment.
Suggested change
| def _get_site_root_overrides( | |
| self, sitesync_addon, project_name, site_name): | |
| def _get_site_root_overrides( | |
| self, sitesync_addon, project_name, site_name | |
| ): |
But, shouldn't that be handled by sitesync addon? Asking for root overrides should return empty dict in that case, or? |
iLLiCiTiT
reviewed
Jul 10, 2024
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
iLLiCiTiT
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Site Sync addon throws ValueError for no local/studio sites as it doesn't make sense to override roots for sftp or gdrive. This handles gracefully this exception.
Testing notes: