Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farm: replace in environment values requires a value #793

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Jul 22, 2024

Changelog Description

This PR provides way how to skip or update values for particular environment variables only for farm rendering.

Additional info

Environment variables on artist machines might be different than on worker machines, maybe pointing to demo license on artist machines and real license on workers etc.

Testing notes:

  1. configure profile
    ayon+settings://core/filter_farm_environment
    image
    (I added temporary variables with Project environments field for easier testing.)
  2. publish on farm, open log of render job and look for :
    Skipping for skipped env vars
    value of modified env var a bit lower when env vars are set from exported .json file

Should be triggered only on farm. Used to modify env var on farm machines like license path etc.
@ynbot
Copy link
Contributor

ynbot commented Jul 22, 2024

@ynbot ynbot added size/S type: feature Adding something new and exciting to the product labels Jul 22, 2024
server/settings/main.py Outdated Show resolved Hide resolved
server/settings/main.py Outdated Show resolved Hide resolved
server/settings/main.py Outdated Show resolved Hide resolved
kalisp and others added 6 commits July 22, 2024 16:39
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
…ture/AY-5998_DL-Search--replace-in-environment-values-requires-a-Value
…ce-in-environment-values-requires-a-Value' into feature/AY-5998_DL-Search--replace-in-environment-values-requires-a-Value
@kalisp kalisp requested a review from iLLiCiTiT July 24, 2024 10:28
server/settings/main.py Outdated Show resolved Hide resolved
server/settings/main.py Outdated Show resolved Hide resolved
server/settings/main.py Outdated Show resolved Hide resolved
kalisp and others added 4 commits July 25, 2024 14:33
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@iLLiCiTiT iLLiCiTiT merged commit d31eb8a into develop Jul 25, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the feature/AY-5998_DL-Search--replace-in-environment-values-requires-a-Value branch July 25, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S type: feature Adding something new and exciting to the product
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants