Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Faster cli initalization #795

Merged
merged 7 commits into from
Jul 23, 2024
Merged

Chore: Faster cli initalization #795

merged 7 commits into from
Jul 23, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Create AddonsManager only once for cli processing.

Additional info

Create only AddonsManager object only single time for whole main cli processing which should make the startup a little bit faster as it does not need to re-fetch all the data.

Testing notes:

  1. All command line commands are working as expected.
  2. The most affected commands are extractenvironments and publish which now do not create addons manager bu expect it as argument. Both are used on farm.

@ynbot ynbot added type: feature Adding something new and exciting to the product size/XS labels Jul 23, 2024
client/ayon_core/cli.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say much about performance differences since I did not test that - but it did work for me over Deadline render (fusion) and publish where the environments did get applied from AYON, etc.

@iLLiCiTiT iLLiCiTiT merged commit adb4fdf into develop Jul 23, 2024
3 checks passed
@iLLiCiTiT iLLiCiTiT deleted the feature/faster-cli-init branch July 23, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: feature Adding something new and exciting to the product
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants