Tray: Make starting tray check faster #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
size/XS
type: enhancement
64qam
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Check if the PID defined in tray info file is alive to make validation of starting tray faster.
Additional info
It happened to me that if tray is brute-force shutdown it does not cleanup the file, so next tray startup takes 10 seconds. Added check if the PID is still alive before any other check.
Testing notes:
Not sure how to exactly replicate the issue. I've started tray in terminal and killed the terminal tab when splash showed up. With that done, the next startup takes at about 10 seconds. With this PR it should be faster.