Validate opening and closing brackets on Anatomy keys.

[robin-ynput]

Changelog Description

Additional fix to address: ynput/ayon-nuke#9 root cause
Currently anatomy keys with unmached [ and ] will be hard failing at formatting attempt. Redirect to AnatomyTemplateUnsolved instead.

Additional info

@iLLiCiTiT this one is mostly to trigger a discussion. See how you like it, I might not have fixed the way it should (hence keeping it as draft). Please feel free to recommend another implementation.

Testing notes:

Introduce a variant] key in the publish/test/directory anatomy setting.

from ayon_core.pipeline import Anatomy, get_current_project_name

prj = get_current_project_name()
ana = Anatomy(prj)
ttt = ana.format(data)
ttt["publish"]["test"]["directory"]

before fix:

  File "C:\Users\robert\AppData\Local\Ynput\AYON\addons\core_0.4.2\ayon_core\pipeline\anatomy\templates.py", line 348, in format
    value = value.format(data, strict)
  File "C:\Users\robert\AppData\Local\Ynput\AYON\addons\core_0.4.2\ayon_core\pipeline\anatomy\templates.py", line 297, in format
    value = value.format(data)
  File "C:\Users\robert\AppData\Local\Ynput\AYON\addons\core_0.4.2\ayon_core\pipeline\anatomy\templates.py", line 96, in format
    result = StringTemplate.format(self, data)
  File "C:\Users\robert\AppData\Local\Ynput\AYON\addons\core_0.4.2\ayon_core\lib\path_templates.py", line 117, in format
    part.format(data, result)
  File "C:\Users\robert\AppData\Local\Ynput\AYON\addons\core_0.4.2\ayon_core\lib\path_templates.py", line 532, in format
    formatted_value = self.template.format(**fill_data)
KeyError: 'variant]'

after fix:

raise AnatomyTemplateUnsolved(ayon_core.pipeline.anatomy.exceptions.AnatomyTemplateUnsolved: Anatomy template "{root[work]}/{project[name]}/{hierarchy}/{folder[name]}/source/{variant]}/v{version:0>3}" is unsolved. Missing keys: "variant]". Keys with invalid data type: `"version" <class 'NoneType'>`.

[BigRoy]

Out of curiosity - after the fix this reports:

AnatomyTemplateUnsolved(ayon_core.pipeline.anatomy.exceptions.AnatomyTemplateUnsolved: Anatomy template "{root[work]}/{project[name]}/{hierarchy}/{folder[name]}/source/{variant]}/v{version:0>3}" is unsolved. Missing keys: "variant]". Keys with invalid data type: "version" <class 'NoneType'>``

Where does that invalid data type of version come from in that report? Seems... unrelated or oddly reported together with the missing key?

[iLLiCiTiT]

Where does that invalid data type of version come from in that report? Seems... unrelated or oddly reported together with the missing key?

What was the template? Or where did you came up with data you've used?

[BigRoy]

What was the template? Or where did you came up with data you've used?

If you're asking me. I took this output report line from @robin-ynput PR description :)

[robin-ynput]

@BigRoy @iLLiCiTiT
{root[work]}/{project[name]}/{hierarchy}/{folder[name]}/source/{variant]}/{@version} in publish/test/directory

[BigRoy]

@BigRoy @iLLiCiTiT {root[work]}/{project[name]}/{hierarchy}/{folder[name]}/source/{variant]}/{@version} in publish/test/directory

I see now. It's just a report of all the invalid things after each other, one one line. It's a bit confusing to read without context but I guess in a way it makes sense? Fine to ignore for me unless we (or just me?) get confused later again.