Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(backend): OutboxFetch #588

Merged
merged 7 commits into from
Dec 26, 2024
Merged

Conversation

penginn-net
Copy link
Collaborator

@penginn-net penginn-net commented Dec 22, 2024

What

Fix: Create(Note)アクティビティを取得できない
Fix: pagelimit が残っていてもcreateLimit以下なら中断する

Why

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 38.33%. Comparing base (af6ad49) to head (43e89de).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...rc/core/activitypub/models/ApOutboxFetchService.ts 0.00% 22 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #588       +/-   ##
============================================
+ Coverage    19.86%   38.33%   +18.46%     
============================================
  Files          797     1692      +895     
  Lines       123092   229720   +106628     
  Branches      1041     3866     +2825     
============================================
+ Hits         24457    88053    +63596     
- Misses       98030   141000    +42970     
- Partials       605      667       +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913
Copy link
Collaborator

Test (federation) を書く必要がある

Copy link
Contributor

github-actions bot commented Dec 22, 2024

이 PR에 의한 api.json 차이
차이점이 없습니다.
Get diff files from Workflow Page

@kozakura913 kozakura913 added this to the 1.2.2 milestone Dec 22, 2024
Copy link
Collaborator

@kozakura913 kozakura913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コードだけ読んでもわかりにくいからコメント増やしてテストも欲しい

@penginn-net penginn-net merged commit 0acc86a into yojo-art:develop Dec 26, 2024
19 of 20 checks passed
@kozakura913 kozakura913 mentioned this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants