Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat:AdvancedSearch/Fix:Reaction Viewer #6

Merged
merged 63 commits into from
May 20, 2024
Merged

Feat:AdvancedSearch/Fix:Reaction Viewer #6

merged 63 commits into from
May 20, 2024

Conversation

1673beta
Copy link
Contributor

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG_CHERRYPICK.md
  • (If possible) Add tests

@penginn-net penginn-net changed the title Advanced search Feat:AdvancedSearch/CustomAchievement Mar 27, 2024
@penginn-net penginn-net marked this pull request as ready for review March 27, 2024 12:48
@penginn-net penginn-net marked this pull request as draft March 27, 2024 12:48
@penginn-net
Copy link
Collaborator

penginn-net commented Mar 27, 2024 •
edited
Loading

実績周りやりたいかもなんもわからん

@penginn-net penginn-net changed the title Feat:AdvancedSearch/CustomAchievement Feat:AdvancedSearch Mar 28, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 14, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@1673beta 1673beta requested a review from kozakura913 May 17, 2024 08:46
@1673beta 1673beta added this to the Release-1 milestone May 17, 2024
This was linked to issues May 17, 2024
高度な検索 #43
Closed
TLのリアクション表示が吹っ飛んでる #45
Closed
@1673beta
Copy link
Contributor Author

1673beta commented May 17, 2024 •
edited
Loading

fix #45,
resolve #43

@penginn-net penginn-net changed the title Feat:AdvancedSearch Feat:AdvancedSearch/Fix:Reaction Viewer May 17, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems May 19, 2024
View reviewed changes
packages/backend/src/server/api/endpoints/notes/advanced-search.ts
export const paramDef = {
type: 'object',
properties: {
// TODO: 整理する

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
@penginn-net
Copy link
Collaborator

自分の方に上げてからにしようとして間違えました・・・
image

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6.7% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@1673beta 1673beta merged commit 6f4933e into develop May 20, 2024
23 of 29 checks passed
@penginn-net penginn-net mentioned this pull request Jul 13, 2024
Closed
1 task
kozakura913 pushed a commit to kozakura913/yojo-art that referenced this pull request Dec 12, 2024
@chan-mai
Merge pull request yojo-art#6 from team-shahu/feat/rev-follow-button
86705bf 
update: docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penginn-net penginn-net penginn-net approved these changes

@kozakura913 kozakura913 Awaiting requested review from kozakura913

Assignees

@1673beta 1673beta

Labels
packages/backend packages/cherrypick-js packages/frontend
Projects
None yet
Milestone
Release-1
Development

Successfully merging this pull request may close these issues.

TLのリアクション表示が吹っ飛んでる 高度な検索
2 participants
@1673beta @penginn-net