Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: PersonのserchableByが正しく連合できていないのを修正 #556

Merged
merged 5 commits into from
Nov 30, 2024

Conversation

penginn-net
Copy link
Collaborator

What

Fix: Actor(Person)のserchableByが正しく連合できていないのを修正
ついでにSerchableBy判別コードを一箇所に

Why

まずい

Additional info (optional)

#519 で抜けてた

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@penginn-net penginn-net added this to the yojo1.2.0 milestone Nov 24, 2024
@penginn-net penginn-net self-assigned this Nov 24, 2024
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 46.55172% with 31 lines in your changes missing coverage. Please review.

Project coverage is 38.47%. Comparing base (f918b11) to head (fb27bb0).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
.../backend/src/core/activitypub/misc/searchableBy.ts 43.18% 25 Missing ⚠️
...end/src/core/activitypub/models/ApPersonService.ts 42.85% 4 Missing ⚠️
.../backend/src/core/activitypub/ApRendererService.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #556      +/-   ##
===========================================
- Coverage    40.06%   38.47%   -1.59%     
===========================================
  Files         1695     1692       -3     
  Lines       235598   229440    -6158     
  Branches      3943     3861      -82     
===========================================
- Hits         94393    88285    -6108     
+ Misses      140579   140530      -49     
+ Partials       626      625       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 24, 2024

이 PR에 의한 api.json 차이
차이점이 없습니다.
Get diff files from Workflow Page

@penginn-net penginn-net merged commit e6eec4c into yojo-art:develop Nov 30, 2024
32 of 33 checks passed
@penginn-net penginn-net deleted the fix-person-serchable branch December 7, 2024 04:20
@kozakura913 kozakura913 mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants