Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Select matched text" should not select っ #980

Closed
Lyroxide opened this issue May 20, 2024 · 4 comments
Closed

"Select matched text" should not select っ #980

Lyroxide opened this issue May 20, 2024 · 4 comments
Labels
kind/bug The issue or PR is regarding a bug

Comments

@Lyroxide
Copy link

Lyroxide commented May 20, 2024

Description
With "Select matched text" option enabled, scanning a word right before the Japanese comma will select the word with the comma.

b7add2fc-366a-4d52-8863-72906effcc8f

Browser version
Firefox 126.0

Yomitan version
24.5.5.0
Not an issue in 23.11.23.0 (Android Kiwi Browser)

Exported settings file
yomitan-settings-2024-05-20-13-24-20.json

@Lyroxide Lyroxide added the kind/bug The issue or PR is regarding a bug label May 20, 2024
@Lyroxide
Copy link
Author

Apparently it is due to my text replacements

image

but I'm not sure if it's intended from #793

There's another similar issue with っ(small tsu) replacement, which is not in my custom text replacements. I thought there used to be setting for that but it's gone?

image

@Lyroxide Lyroxide changed the title "Select matched text" should not select 、 "Select matched text" should not select っ May 23, 2024
@Geniusssmit
Copy link

I have the same issue with っ
image

@Geniusssmit
Copy link

" " should also be skipped I think
image

@Geniusssmit
Copy link

also mining this this word from this sentence with
{cloze-prefix}<b>{cloze-body}</b>{cloze-suffix}
bolds different characters for some reason
ボウ<b>フウリ</b>ン総代 梅宮一だ。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

No branches or pull requests

3 participants